perf(acpmux): reserve prompt image slots during host load by teamleaderleo · Pull Request #21383 · manaflow-ai/cmux

teamleaderleo · 2026-10-17T23:03:07Z

Problem

Prompt attachments are fetched asynchronously from the native host. The transcript row is measured before the image arrives, so a late thumbnail insertion can push the prompt and every row below it down after the initial paint.

Change

Render a fixed 72px checker placeholder while the host reads a sent prompt image.
Swap in the decoded image with the existing cv-enter compositor-only motion token.
Keep missing images on the previous empty fallback path.

This reserves the vertical slot before the async response and keeps the reveal calm without changing image sizing or reduced-motion behavior.

Validation

git diff --check
Fleet CI should run the web typecheck, tests, React Doctor, compiler, and gallery checks.

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by cubic

Reserves a 72px placeholder while the host reads a sent prompt image so the transcript row no longer shifts when the thumbnail arrives late. If the read fails (after a reconnect or session switch) the slot is cleared so a stale thumbnail never lingers; missing images keep the previous empty fallback.

^{Written for commit 3ad69d2. Summary will update on new commits.}

coderabbitai · 2026-10-17T23:03:16Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 57ebf77a-92d8-461d-855d-0819dce0d0bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-17T23:05:15Z

all web/size checks green

github-actions · 2026-10-17T23:05:33Z

Passes: CI passes on 3ad69d2fe3.

CI passes on 3ad69d2fe3 (run 39093163430 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

github-actions · 2026-10-17T23:06:03Z

CI fast guards passes on 3ad69d2fe3 (https://github.com/manaflow-ai/cmux/actions/runs/39093163430). This covers only the fast guards, not CI: CI's result is the ci-status check, and the CI failure attribution comment names any failing test.

teamleaderleo · 2026-10-17T23:08:15Z

Bead cx-gwc27 created for this PR by the cmux coordinator.

- vp fmt webviews/test/sent-image-lifecycle.test.tsx Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39080902701

cursor · 2026-10-18T00:07:43Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

- vp fmt webviews/test/sent-image-lifecycle.test.tsx Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39081616425

blacksmith-sh · 2026-10-18T00:35:16Z

Found 2 test failures on Blacksmith runners:

Failures

Test	View Logs
`test/apps-flow.test.ts/apps-flow.test`	View Logs
`test/apps-flow.test.ts/apps-flow.test`	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

cursor · 2026-10-18T03:18:39Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

github-actions · 2026-10-18T03:18:49Z

Visual review: HQ feed · workflow run

github-actions · 2026-10-18T03:54:10Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39094946537 at fd53bb8 failed: cmux-next Release compile (Xcode 26).
Those jobs last passed at fde94c5. This pull request is one of 1 merged since: #21383.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-18T03:55:33Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39095141726 at afec4de failed: cmux-next Release compile (Xcode 26).
Those jobs last passed at fde94c5. This pull request is one of 3 merged since: #21383, #21446, #21384.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-18T04:10:46Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39095228117 at 9e14d7a failed: cmux-next Release compile (Xcode 26).
Those jobs last passed at fde94c5. This pull request is one of 3 merged since: #21383, #21446, #21384.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-18T04:37:15Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39096093835 at b246059 failed: cmux app scheme compile (Debug), cmux-next Release compile (Xcode 26).
Those jobs last passed at fde94c5. This pull request is one of 5 merged since: #21383, #21446, #21384, #21450, #21442.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

#22024) * test(cmux-next): the agent pane keeps the wiring the #21331 merge dropped Fails on feat-cmux-next (5 of 5): the #21331 branch was rebased onto a tree without #21194, #21344 and #21383, so its merge left the Chief Dock unmounted, the Debug Settings turn footer placement unapplied, disclosures keyed without their chat, and the sent-image slot and reply-image fade without CSS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cmux-next): restore the agent pane wiring the #21331 merge dropped Re-applies the hunks e124e93 (#21331's branch) removed from its base 50a0c60 without meaning to, and only those: - App.tsx: the quick surface gets the Chief Dock again (#21194, behind its experiment); the theme push applies turnActionsPlacement (#21344); tool and edited-file rows carry the chat's sessionId into their disclosures (#21344). - conversation.css: the 72px .cv-user__image-placeholder slot (#21383), the left turn-actions placement rules (#21344) and the .cv-img--enter fade. #21331's own follow-bottom deadband, THREAD_TOP and overflow-anchor changes stay as they are. The effort track motion that branch also dropped is already back on the tip (#21512). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 896b604 - vp fmt webviews/src/agent-session/acpmux/replyHref.ts - vp fmt webviews/src/pages/markdown/README.md - vp fmt webviews/src/pages/markdown/links.ts - vp fmt webviews/test/markdown-cmux-app-links.test.ts Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39212624868 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cmux-autofix[bot] <cmux-autofix[bot]@users.noreply.github.com>

perf(acpmux): reserve prompt image slots during host load

56cf34d

style(acpmux): format prompt image placeholder

a7f3a76

teamleaderleo and others added 6 commits October 17, 2026 16:12

style(acpmux): apply webview formatter

05b8a10

fix(acpmux): clear failed prompt image reservations

35fb2e2

test(acpmux): cover sent-image rejection lifecycle

3cacd5c

style(acpmux): format sent-image lifecycle test

8920855

chore(next): PR autofix at 8920855

ce37467

- vp fmt webviews/test/sent-image-lifecycle.test.tsx Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39080902701

style(acpmux): apply repository Vite+ formatter

85c79b6

cmux-autofix[bot] and others added 2 commits October 18, 2026 00:14

chore(next): PR autofix at 85c79b6

cdeca17

- vp fmt webviews/test/sent-image-lifecycle.test.tsx Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39081616425

style(acpmux): match repository Vite+ formatting

442decd

manaflow-ai deleted a comment from github-actions Bot Oct 18, 2026

test(next): carry apps empty-state selector through PR 21383

3ad69d2

teamleaderleo merged commit fd53bb8 into feat-cmux-next Oct 18, 2026
103 checks passed

teamleaderleo deleted the perf/prompt-image-reservation branch October 18, 2026 03:49

This was referenced Oct 18, 2026

test(apps): tolerate empty-state selector rename #21446

Merged

perf(cmux-next): gate find highlight repaints by transcript changes #21384

Merged

github-actions Bot mentioned this pull request Oct 18, 2026

fix(setup): install hooks before toolchain checks #21450

Merged

github-actions Bot mentioned this pull request Oct 18, 2026

Gallery: make current-composer handoff fast and shareable #21442

Merged

This was referenced Oct 19, 2026

fix(cmux-next): restore the agent pane wiring the #21331 merge dropped #22024

Merged

test(next): the Quick Composer shows the Chief Dock (regression test for #22024) #22514

Closed

teamleaderleo mentioned this pull request Oct 21, 2026

Agent chat: sent images keep their shape and never blink on a re-render #23734

Merged

Conversation

teamleaderleo commented Oct 17, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Change

Validation

Summary by cubic

Uh oh!

coderabbitai Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teamleaderleo commented Oct 17, 2026

Uh oh!

cursor Bot commented Oct 18, 2026

Bugbot needs on-demand usage enabled

Uh oh!

blacksmith-sh Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failures

Uh oh!

cursor Bot commented Oct 18, 2026

Bugbot needs on-demand usage enabled

Uh oh!

github-actions Bot commented Oct 18, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 18, 2026

Uh oh!

github-actions Bot commented Oct 18, 2026

Uh oh!

github-actions Bot commented Oct 18, 2026

Uh oh!

github-actions Bot commented Oct 18, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 17, 2026 •

edited by cubic-dev-ai Bot

Loading

coderabbitai Bot commented Oct 17, 2026 •

edited

Loading

github-actions Bot commented Oct 17, 2026 •

edited

Loading

github-actions Bot commented Oct 17, 2026 •

edited

Loading

github-actions Bot commented Oct 17, 2026 •

edited

Loading

blacksmith-sh Bot commented Oct 18, 2026 •

edited

Loading