Repository navigation
fix(agent-pane): settle follow at the streaming bottom - #21371
teamleaderleo wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visual preview of d95c7ac: in the maintainers' private review feed. |
|
Bead |
Gallery24 states changed: agent-pane.chat-width/wide, agent-pane.chat-width/wide-blocks, agent-pane.transcript/math-delimiters, agent-pane.transcript/github-references, agent-pane.replay/playing, ... · 1 play check failed Diff page and renders (the run's 18 more on the diff page. Live preview (follows this branch; start it with
Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):
69 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes. |
|
Superseded by #21363, which carries the current-base follow fix plus the cx-ncc.58 composer-slot regression and focused tests. |






Summary
Narrow the WebKit follow repair to the current
feat-cmux-nextbase. Streaming bottom-following now uses a 2 px resting deadband and only writes a meaningful correction, preserving the follow trace across a second composer send without carrying the unrelated sidebar/motion changes from #21331.Validation
bun test test/transcript-follow.test.ts(browser lane skipped outside CI/Freestyle)CMUX_BROWSER_TESTS=1 bun test test/transcript-follow.test.ts(local DOM timeout while starting the Vite browser lane; hosted WebKit remains required)bun run typecheck(no type errors in 1482 files)git diff --checkThe existing transcript-follow browser test already asserts the <=2px follow tolerance. Hosted WebKit/Chromium validation is required on this exact head before merge.
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Sets bottom-following to a 2px resting deadband in the agent transcript, so streaming replies no longer write fractional scroll offsets and twitch the thumb.
settleFollowBottomhelper only corrects when displacement exceeds the deadband, which also preserves the follow trace across a second composer send.feat-cmux-nextbase; unrelated sidebar and motion changes are not carried over.Written for commit d95c7ac. Summary will update on new commits.