Skip to content

Print OK for cmux vm restart like pause and resume - #20526

Merged
austinywang merged 1 commit into
mainfrom
fix-vm-restart-ok-output
Oct 14, 2026
Merged

austinywang merged 1 commit into
mainfrom
fix-vm-restart-ok-output

Conversation

@austinywang

@austinywang austinywang commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

CLINotifyProcessIntegrationRegressionTests/testVMRestartSendsTheProviderRecoveryMethod() failed on main CI run 38534940101 (shard 5/7, RATCHET_NEW_FAILURE):

CLIVMLayoutEnvTests.swift:965: XCTAssertTrue failed - frozen-vm restarted (status=running)

#20361 added cmux vm restart and this test together. cmux vm pause and cmux vm resume print OK <id> …, the success token scripts look for. Restart printed only the localized <id> restarted (status=…), so the output didn't match its siblings and the test expecting OK failed. This is an app inconsistency, not a test problem.

Fix: print OK before the localized text, so the token is the same in every locale. Translations are unchanged.

Follows #20459 and #20502, which fixed the other app-host failures on main.

Verification

  • scripts/verify-local.py: swift-syntax, localization-defaults and feature-flags passed.
  • Red: main run 38534940101. Green: this PR's CI.

Changelog

Fixed: cmux vm restart prints OK on success, like cmux vm pause and cmux vm resume.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

cmux vm restart now prints OK on success, matching cmux vm pause and cmux vm resume.

This fixes CLINotifyProcessIntegrationRegressionTests/testVMRestartSendsTheProviderRecoveryMethod(), which failed because restart printed only the localized <id> restarted (status=…) while the success token scripts and the test expect OK as a prefix. The OK token is printed outside the localized text so it stays identical across locales; translations are unchanged.

Written for commit 48b2ed6. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Updates
    • The vm restart response now begins with “OK”.

#20361 added cmux vm restart and its test. pause and resume print
"OK <id> ...", the success token scripts look for, but restart printed
only the localized "<id> restarted (status=...)", so the new test failed
on main. Print the OK prefix outside the localized text so it is the
same in every locale.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 61c934f6-02b9-4f75-b843-5ff855930909
📥 Commits

Reviewing files that changed from the base of the PR and between 150b81d and 48b2ed6.

📒 Files selected for processing: 1
  • CLI/cmux.swift
 ________________________________________________________________
< Just keep coding, just keep coding... I'll handle the reviews. >
 ----------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@austinywang
austinywang merged commit 62f5cb2 into main Oct 14, 2026
62 of 63 checks passed
@austinywang
austinywang deleted the fix-vm-restart-ok-output branch October 14, 2026 09:05
@github-actions

Copy link
Copy Markdown
Contributor

Merge receipt for 48b2ed640f, merged 2026-10-14 09:05:55 UTC

  • Not verified at merge: ci-status (not reported), macOS compile admission (in progress)
  • Verified: backend migrations applied, CI fast guards, Fast static checks, guards (18), macOS admission gate, plan, web-validation
  • Skipped by policy: admission-placement, apply-production, apply-staging, browser, Claude wrapper regressions, Dogfood build #​${{ github.event.pull_request.number }}, GhosttyKit release check, linux-preflight, remote-daemon, suite-coverage, swift-package-tests, ui-tests, and 4 more
  • Full suite: runs on main after merge.

Labeled merged-unverified: if main breaks near this merge, look here first.

@github-actions github-actions Bot added the merged-unverified A judging check was not green at merge; see the merge receipt comment label Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Machine: the runner failed, not this PR. Not re-run: this PR has merged.

CI failed on 48b2ed640f (run 38539249730 attempt 1): 2 machine.

Job Verdict Why
macos / CLI regressions (2/3) machine the owned runner refused the job (host busy or out of capacity) (runner cmux-austin-mini-0-glaeda)
macos / CLI regressions (1/3) machine the owned runner refused the job (host busy or out of capacity) (runner cmux-austin-mini-1-glaeda)
Matched log lines
macos / CLI regressions (2/3): glaeda-cmux-runner-hook: refused: node not eligible (rust toolchain 1.98.1-aarch64-apple-darwin is not installed)
macos / CLI regressions (1/3): glaeda-cmux-runner-hook: refused: node not eligible (rust toolchain 1.98.1-aarch64-apple-darwin is not installed)

Not re-run: this PR has merged.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-unverified A judging check was not green at merge; see the merge receipt comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant