Repository navigation
Print OK for cmux vm restart like pause and resume - #20526
Conversation
#20361 added cmux vm restart and its test. pause and resume print "OK <id> ...", the success token scripts look for, but restart printed only the localized "<id> restarted (status=...)", so the new test failed on main. Print the OK prefix outside the localized text so it is the same in every locale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merge receipt for
Labeled |
|
Machine: the runner failed, not this PR. Not re-run: this PR has merged. CI failed on
Matched log linesNot re-run: this PR has merged. Written by |
Summary
CLINotifyProcessIntegrationRegressionTests/testVMRestartSendsTheProviderRecoveryMethod()failed on main CI run 38534940101 (shard 5/7,RATCHET_NEW_FAILURE):#20361 added
cmux vm restartand this test together.cmux vm pauseandcmux vm resumeprintOK <id> …, the success token scripts look for. Restart printed only the localized<id> restarted (status=…), so the output didn't match its siblings and the test expectingOKfailed. This is an app inconsistency, not a test problem.Fix: print
OKbefore the localized text, so the token is the same in every locale. Translations are unchanged.Follows #20459 and #20502, which fixed the other app-host failures on main.
Verification
scripts/verify-local.py: swift-syntax, localization-defaults and feature-flags passed.Changelog
Fixed:
cmux vm restartprintsOKon success, likecmux vm pauseandcmux vm resume.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
cmux vm restartnow printsOKon success, matchingcmux vm pauseandcmux vm resume.This fixes
CLINotifyProcessIntegrationRegressionTests/testVMRestartSendsTheProviderRecoveryMethod(), which failed because restart printed only the localized<id> restarted (status=…)while the success token scripts and the test expectOKas a prefix. The OK token is printed outside the localized text so it stays identical across locales; translations are unchanged.Written for commit 48b2ed6. Summary will update on new commits.
Summary by CodeRabbit
vm restartresponse now begins with “OK”.