Repository navigation
Fix the Cloud command timeout test after the request-deadline error split - #20502
Conversation
#20376 gave a persistent channel's per-request deadline its own error, LinkError.requestTimedOut, separate from the connect timeout. The app already classifies it as a timeout and as retryable, but this test still caught only .timedOut, so the deadline it waits for escaped as an uncaught error. Catch the error the channel now throws, and check that same error is retryable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Merge receipt for
Labeled |
|
Machine: the runner failed, not this PR. Not re-run: this PR has merged. CI failed on
Matched log linesNot re-run: this PR has merged. Written by |
Summary
Main CI run 38524277453 (aad8350) reported five app-host tests as
RATCHET_NEW_FAILURE. Four were already fixed by #20459, which landed after that run. This PR fixes the fifth.CloudWorkspaceCreationRevealTests/closingTheWindowDuringShortcutReleasesItsManager(entryPoint:)(shard 5/7)SurfaceResumeAgentBindingGenerationTests/staleCachedSessionCannotAuthorizeCurrentBinding()(shard 4/7)isComplete(), so a rejected stale checkpoint left the agent counted as running and restore replayed a dead binding.MuseVaultRegistrationTests/vaultListsMuseSessions()(shard 3/7)cdprefix since August.GhosttyMinimumContrastLayerBackgroundTests/darkTextOnLightThemeStaysDark()(shard 3/7)CloudCommandOperationTests/commandTimeoutLeavesRecoverableOperationVisibleAfterLaterSuccess()(shard 6/7)LinkError.requestTimedOutfor a channel's per-request deadline, and the app classifies it as.timeoutand retryable. The test still caught only.timedOut, so the expected deadline error escaped asCaught error: requestTimedOutafter 4 ms.requestTimedOutand check that the same error is retryableVerification
CloudCommandOperationTests: this PR's CI (the changed suite).Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the Cloud command timeout test, which broke after #20376 split the per-request deadline error from the connect timeout. The app now throws
LinkError.requestTimedOutfor a channel's per-request deadline, but the test still caught only.timedOut, so the expected deadline escaped as an uncaught error.requestTimedOutand assert that the same error is retryable.Written for commit 198f6dd. Summary will update on new commits.