cmux-next: New Tab tabs draw the new-tab icon, not the agent chat bubble by teamleaderleo · Pull Request #17630 · manaflow-ai/cmux

teamleaderleo · 2026-10-06T19:15:01Z

Summary

Fixes item 15 of the cmux-next sweep (cmuxterm-hq#1421): Agent tabs and New Tab tabs shared the generic chat bubble. Both ride a conversation record, and TabItemMapping gave every conversation tab agent.chat.

The pane already knows which tabs are still on the New Tab page (AgentTabs.pageTabs), since it titles them "New Tab". It now passes that to the mapping, and those tabs draw the registry's tab.new.

Tab	Was	Now
New Tab page	`agent.chat`	`tab.new`
Agent chat with a known harness	harness mark	harness mark (unchanged)
Agent chat without a harness mark	`agent.chat`	`agent.chat` (unchanged)

Converted call sites:

TabItemMapping.item(_:fallbackTitle:isNewTabPage:): new isNewTabPage flag, default false.
PaneController.snapshot(): computes isNewTabPage once and uses it for both the title and the icon.

When a New Tab page becomes a chat, its title and icon change in the same snapshot.

Not changed:

Workspace-row kind icons. They are pending Leo's call.
The sidebar's tab list. It doesn't know which tabs are New Tab pages (it also titles them from the record), so it keeps agent.chat for them. Follow-up: give SidebarTabKind a new-tab case once the sidebar gets that state.

Testing

Red commit d6ea400 adds ConversationTabItemTests.aNewTabPageTabDrawsTheNewTabIcon; the fix follows. The same conversation record maps to tab.new as a New Tab page and to agent.chat as a chat.

Changelog

Fixed: New Tab tabs show a new-tab icon instead of the agent chat bubble

Demo Video

Fleet builds of base (ff267c4) and the fix, on a capture mini (1x display), opening a workspace's first New Tab.

New Tab tab at 6x, before (top) and after (bottom):

Before	After

Checklist

Behavior changes have added or updated tests, or Testing says why not
UI change with no new or changed user-facing strings; localization not affected

🤖 Generated with Claude Code

…ubble Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

A tab still on the New Tab page and an Agent chat tab both rode a conversation record and drew the agent chat bubble. The pane knows which tabs are New Tab pages; it now tells the mapping, which draws tab.new. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cursor · 2026-10-06T19:15:06Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

coderabbitai · 2026-10-06T19:15:12Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 53fa86f5-d0c2-45c2-b7b9-e9d0ef2d12a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-06T19:16:40Z

Not verified: macOS jobs did not run: compile and app tests were skipped on 9be9a2eae5; ci-status is green without them.

CI passes on 9be9a2eae5 (run 37549559618 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

…ns-8

teamleaderleo · 2026-10-06T19:42:13Z

Batch queue: green. Batch stack 1a07d268cf62 on feat-cmux-next 423bd8a882c8 with #17584 #17602 #17609 #17611 #17625 #17630 #17633. Fleet production build: job 07b1c1720d6973c1d000950b (cmux-ci artifact 07b1c1720d6973c1d000950b (job 07b1c1720d6973c1d000950b, tag nb-local-20261006-192713-1)). heavy tier did not run on this branch (run); your PR's own checks are the tests. Validated this PR at 4527a78193a3.

Next: land it yourself with gh-merge-green on this receipt.

…ns-8

cursor · 2026-10-06T20:28:24Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

…ns-8

teamleaderleo · 2026-10-06T22:42:05Z

Batch queue: green. Batch stack 302099401834 on feat-cmux-next ebac81f0c771 with #17609 #17620 #17630. Fleet production build: job 5283f103448a81da175c7814 (cmux-ci artifact 5283f103448a81da175c7814 (job 5283f103448a81da175c7814, tag nb-local-20261006-223112-1)). heavy tier did not run on this branch (run); your PR's own checks are the tests. Validated this PR at 4171758ff58e.

Next: land it yourself with gh-merge-green on this receipt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo · 2026-10-06T23:10:28Z

Batch queue: green. Batch stack b2ae9b9ef0f0 on feat-cmux-next 044508d44ee8 with #17609 #17611 #17620 #17623 #17630 #17633 #17635 #17636 #17648. Fleet production build: job d26b5daf716cd175c2f38aa0 (cmux-ci artifact d26b5daf716cd175c2f38aa0 (job d26b5daf716cd175c2f38aa0, tag nb-local-20261006-225524-1)). heavy tier did not run on this branch (run); your PR's own checks are the tests. Validated this PR at fd235a9e615c.

Next: land it yourself with gh-merge-green on this receipt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo · 2026-10-07T00:38:12Z

Batch queue: green. Batch stack c2b7744fd7cc on feat-cmux-next ac66021d2193 with #17551 #17601 #17620 #17623 #17630 #17635 #17643 #17644. Fleet production build: job 267908eced53b1284e673af5 (cmux-ci artifact 267908eced53b1284e673af5 (job 267908eced53b1284e673af5, tag nb-local-20261007-000439-1)). heavy tier did not run on this branch (run); your PR's own checks are the tests. Validated this PR at 9be9a2eae561.

Next: land it yourself with gh-merge-green on this receipt.

teamleaderleo · 2026-10-07T01:02:25Z

merge-override: Base red: StaticSidebarToggleTests.withTheSidebarHiddenTheStripStartsAfterTheToggle fails identically on #17620/#17630/#17635 (unrelated surfaces), own tests pass, other reds are runner refusals; owner approved override

github-actions · 2026-10-07T01:05:35Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37555112268 at 2df79b5 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at d7167cb. This pull request is one of 3 merged since: #18115, #17630, #17635.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-07T01:05:36Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37555118221 at ea3879d failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at d7167cb. This pull request is one of 4 merged since: #18115, #17630, #17635, #17535.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

teamleaderleo and others added 2 commits October 6, 2026 12:14

test: a New Tab page tab draws the new-tab icon, not the agent chat b…

d6ea400

…ubble Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo mentioned this pull request Oct 6, 2026

cmux-next: sidebar tab list draws New Tab tabs with the new-tab icon and title #17635

Merged

2 tasks done

Merge remote-tracking branch 'origin/feat-cmux-next' into op-next-ico…

4527a78

…ns-8

teamleaderleo mentioned this pull request Oct 6, 2026

cmux-next: location row names the Mac and moves a started chat's folder #17584

Merged

teamleaderleo mentioned this pull request Oct 6, 2026

cmux-next: hover swaps an unread row's badge for its x in place #17625

Merged

azooz2003-bit mentioned this pull request Oct 6, 2026

cmux-next: sidebar tab list draws New Tab tabs with the new-tab icon and title #17683

Closed

2 tasks done

azooz2003-bit closed this Oct 6, 2026

Merge remote-tracking branch 'origin/feat-cmux-next' into op-next-ico…

0e27414

…ns-8

azooz2003-bit mentioned this pull request Oct 6, 2026

cmux-next: New Tab tabs draw the new-tab icon, not the agent chat bubble #17914

Closed

2 tasks done

azooz2003-bit reopened this Oct 6, 2026

azooz2003-bit mentioned this pull request Oct 6, 2026

cmux-next: sidebar tab list draws New Tab tabs with the new-tab icon and title #17938

Closed

2 tasks done

azooz2003-bit closed this Oct 6, 2026

azooz2003-bit mentioned this pull request Oct 6, 2026

cmux-next: New Tab tabs draw the new-tab icon, not the agent chat bubble #17940

Closed

2 tasks done

azooz2003-bit reopened this Oct 6, 2026

azooz2003-bit closed this Oct 6, 2026

azooz2003-bit reopened this Oct 6, 2026

Merge remote-tracking branch 'origin/feat-cmux-next' into op-next-ico…

4171758

…ns-8

This was referenced Oct 6, 2026

cmux-next: archive a chat from its menu, Codex-style #17609

Merged

cmux-next: Feed kinds, inbox controls and GitHub actions draw registry icons #17620

Merged

Merge feat-cmux-next into op-next-icons-8

fd235a9

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This was referenced Oct 6, 2026

cmux-next: open a chat in a new window from its menu #17611

Merged

cmux-next: no stray space dot with one space #17623

Merged

This was referenced Oct 6, 2026

cmux-next: keep the omnibar edit through a light/dark switch #17633

Merged

cmux-next: tab hover cards without empty thumbnails or unavailable text #17636

Merged

cmux-next: composer bar fits a narrow pane #17648

Closed

Merge feat-cmux-next into op-next-icons-8

9be9a2e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This was referenced Oct 7, 2026

fix(cmux-next): App Store pages join Back/Forward; centered detail page without capsules #17551

Merged

cmux-next sidebar: signed-in user on the profile control #17601

Merged

This was referenced Oct 7, 2026

test(cmux-next): palette and terminal deadline tests wait for the work, not the clock #17643

Merged

fix(cmux-next): the diff sidecar's request deadline starts at its ready marker #17644

Merged

teamleaderleo merged commit db1a87d into feat-cmux-next Oct 7, 2026
61 of 74 checks passed

teamleaderleo deleted the op-next-icons-8 branch October 7, 2026 01:02

github-actions Bot mentioned this pull request Oct 7, 2026

cmux-next: align composer context and effort controls #18115

Merged

github-actions Bot mentioned this pull request Oct 7, 2026

ci(cmux-next): implicit batch queue for feat-cmux-next #17535

Merged

Navigation Menu

Repository navigation

cmux-next: New Tab tabs draw the new-tab icon, not the agent chat bubble - #17630

cmux-next: New Tab tabs draw the new-tab icon, not the agent chat bubble#17630
teamleaderleo merged 7 commits into
feat-cmux-nextfrom
op-next-icons-8

teamleaderleo commented Oct 6, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Oct 6, 2026

Uh oh!

coderabbitai Bot commented Oct 6, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Oct 6, 2026 •

edited

Loading

Uh oh!

teamleaderleo commented Oct 6, 2026

Uh oh!

cursor Bot commented Oct 6, 2026

Uh oh!

teamleaderleo commented Oct 6, 2026

Uh oh!

teamleaderleo commented Oct 6, 2026

Uh oh!

teamleaderleo commented Oct 7, 2026

Uh oh!

teamleaderleo commented Oct 7, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

teamleaderleo commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Changelog

Demo Video

Checklist

Uh oh!

cursor Bot commented Oct 6, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

coderabbitai Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teamleaderleo commented Oct 6, 2026

Uh oh!

cursor Bot commented Oct 6, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

teamleaderleo commented Oct 6, 2026

Uh oh!

teamleaderleo commented Oct 6, 2026

Uh oh!

teamleaderleo commented Oct 7, 2026

Uh oh!

teamleaderleo commented Oct 7, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

teamleaderleo commented Oct 6, 2026 •

edited

Loading

coderabbitai Bot commented Oct 6, 2026 •

edited

Loading

github-actions Bot commented Oct 6, 2026 •

edited

Loading