Skip to content

Restore the four-button pane tab bar in narrow panes - #17397

Merged
austinywang merged 1 commit into
mainfrom
restore-four-button-tabbar
Oct 5, 2026
Merged

austinywang merged 1 commit into
mainfrom
restore-four-button-tabbar

Conversation

@austinywang

@austinywang austinywang commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

The pane tab bar still differed from 0.64.25 after #17395 and #17396. Bonsplit 920b936 ("fix: collapse tab actions in narrow panes", Sep 30) collapsed the four action buttons into one … menu in any pane narrower than 520pt. That covers most split panes.

This PR bumps vendor/bonsplit from 64ac6d4 to 8bc81c8 (manaflow-ai/bonsplit#273), which removes that collapse:

  • deletes isNarrowPane, splitActionButtonCount and collapsedSplitButtonMenu
  • the lane always lays out every configured button again

The bump moves forward from the current pin and does not include bonsplit #272.

Audit against v0.64.25: splitButtonsOnHover is still false in cmux, and SplitActionButton.defaults is unchanged. After this PR, no other Bonsplit or cmux change since v0.64.25 alters which pane tab bar buttons are shown.

Verification: the Bonsplit package tests could not run locally because the cmux-lawrence-2 build-host alias is missing on this machine (REPAIR.md row 105). The Bonsplit and cmux CI on these PRs is the compile and test signal.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Restores the four-button pane tab bar in narrow panes by bumping vendor/bonsplit to 8bc81c8 (manaflow-ai/bonsplit#273). The previous pin collapsed the pane tab bar's action buttons into a single ellipsis menu in any pane narrower than 520pt; the new pin always lays out every configured button again.

Verification:

  • The bump moves forward from 64ac6d4 and does not include bonsplit Follow up PR 242: refresh browser under-page background on theme updates #272.
  • splitButtonsOnHover remains false and SplitActionButton.defaults is unchanged, so no other change since v0.64.25 affects which pane tab bar buttons show.
  • Bonsplit package tests could not run locally because the cmux-lawrence-2 build-host alias is missing; Bonsplit and cmux CI on the PRs provide the compile and test signal.

Written for commit 59c5780. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Updated a bundled third-party component. No user-visible changes are specified.

Bumps vendor/bonsplit to 8bc81c8 (manaflow-ai/bonsplit#273), which removes
the narrow-pane collapse that replaced the pane tab bar's action buttons
with a single ellipsis menu below 520pt. The pin moves forward from
64ac6d4 and does not include bonsplit#272.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@austinywang

Copy link
Copy Markdown
Contributor Author

Subagent correctness review: no correctness issues found. Source and history review only; nothing was built or run.

  • Bonsplit 8bc81c8 leaves no references to the removed narrow-pane symbols in Sources or Tests, and none on the cmux side. splitButtonChrome and tabBarLayout are back to the v0.64.25 form, and no localized string is left orphaned.
  • Between faf8418 (the v0.64.25 pin) and 8bc81c8, the only width-based change to which buttons show was 920b936/b281035, and this PR removes it. 98c35a8 (splitButtonsOnHover) has no effect because cmux sets that flag to false. The other commits change icon caching, accessibility labels, or tab-strip scrolling and hover, not which buttons appear.
  • Tests: fullActionLaneWidth = 600 still renders the full lane. The two tests removed from TabBarLayoutFeedbackTests only covered the deleted helpers.
  • cmux side: the Revert compact pane tab bar menus #17395 revert is clean and the default buttons are unchanged. One difference from v0.64.25 is by design: fix: hide browser affordances while the browser is disabled (#10866) #13023 hides the browser button when the browser is turned off, and hides flagged actions when their flags are off. All four buttons show with default settings.
  • The submodule moves forward by exactly one commit (64ac6d4 → 8bc81c8) and does not include bonsplit#272.

Resolution: no changes needed.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4d9aac7b-8f51-4562-8e89-a0523acb77b7
📥 Commits

Reviewing files that changed from the base of the PR and between 4cfda5c and 59c5780.

📒 Files selected for processing (1)
  • vendor/bonsplit
 __________________________________________
< Given enough GPUs, all bugs are shallow. >
 ------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@austinywang
austinywang merged commit f0cf16d into main Oct 5, 2026
63 of 64 checks passed
@austinywang
austinywang deleted the restore-four-button-tabbar branch October 5, 2026 15:29
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Merge receipt for 59c578095a, merged 2026-10-05 15:29:35 UTC

  • Not verified at merge: ci-status (not reported), macOS compile admission (in progress), guards (18) (in progress), swift-package-tests (in progress)
  • Verified: backend migrations applied, CI fast guards, Fast static checks, GhosttyKit release check, plan, Web complexity, web-validation
  • Skipped by policy: admission-placement, apply-production, apply-staging, browser, Claude wrapper regressions, Dogfood build #​${{ github.event.pull_request.number }}, full-suite-coverage, remote-daemon, suite-coverage, web, web-build, web-database-tests, and 1 more
  • Full suite: runs on main after merge.

Labeled merged-unverified: if main breaks near this merge, look here first.

@github-actions github-actions Bot added the merged-unverified A judging check was not green at merge; see the merge receipt comment label Oct 5, 2026
@austinywang austinywang mentioned this pull request Oct 5, 2026
rustybret pushed a commit to rustybret/bmux that referenced this pull request Oct 5, 2026
e859bda Release v0.65.0 (manaflow-ai#17398)
26a1a29 Fix flattened CodeRouter test filtering (manaflow-ai#17399)
f0cf16d Restore the four-button pane tab bar in narrow panes (manaflow-ai#17397)
@lucasr1b lucasr1b mentioned this pull request Oct 8, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-unverified A judging check was not green at merge; see the merge receipt comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant