Skip to content

Follow up PR 242: refresh browser under-page background on theme updates - #272

Merged
lawrencecchen merged 5 commits into
mainfrom
task-242-remove-border-below-titlebar-followup
Feb 21, 2026
Merged

lawrencecchen merged 5 commits into
mainfrom
task-242-remove-border-below-titlebar-followup

Conversation

@lawrencecchen

Copy link
Copy Markdown
Contributor

Summary

  • Refresh WKWebView.underPageBackgroundColor when .ghosttyDefaultBackgroundDidChange fires so already-open browser panels track runtime theme/background updates
  • Add a regression test that posts the background-change notification and verifies the browser under-page color updates
  • Keep the titlebar border unchanged (per requested scope)

Testing

  • xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux-unit -configuration Debug -destination 'platform=macOS' -only-testing:cmuxTests/BrowserDeveloperToolsConfigurationTests/testBrowserPanelRefreshesUnderPageBackgroundColorWhenGhosttyBackgroundChanges test (passes)
  • xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux -configuration Debug -destination 'platform=macOS' build (passes)
  • ./scripts/reload.sh --tag pr242-followup (passes)

Related

@vercel

vercel Bot commented Feb 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Feb 21, 2026 1:23pm

@lawrencecchen
lawrencecchen merged commit 8ac554f into main Feb 21, 2026
5 checks passed
@lawrencecchen
lawrencecchen deleted the task-242-remove-border-below-titlebar-followup branch February 21, 2026 13:30
bn-l pushed a commit to bn-l/cmux that referenced this pull request Apr 3, 2026
…tes (manaflow-ai#272)

* Address PR 242 follow-ups for titlebar and browser background

* Restore titlebar border per follow-up scope

* Refresh browser under-page color with Ghostty opacity

* Browser: theme blank page fallback for about:blank

* Browser: keep new tabs webview-less until first nav
@lucasr1b lucasr1b mentioned this pull request Oct 8, 2026
3 tasks done

This branch was successfully deployed

1 active deployment
Preview — 7e811d90 Deployed Feb 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant