Skip to content

Restore the four-button action lane in narrow panes - #273

Merged
austinywang merged 2 commits into
mainfrom
restore-four-button-tabbar
Oct 5, 2026
Merged

austinywang merged 2 commits into
mainfrom
restore-four-button-tabbar

Conversation

@austinywang

@austinywang austinywang commented Oct 5, 2026 •

Copy link
Copy Markdown

Removes the narrow-pane collapse from 920b936 ("fix: collapse tab actions in narrow panes") and b281035. Below 520pt the pane tab bar replaced its action buttons with a single ellipsis menu. This brings back the 0.64.25 behavior: every configured action button shows at any width.

This branch is cut from 64ac6d4, the revision cmux main pins. That keeps #272's menu work (backed out of cmux in manaflow-ai/cmux#17396) out of the pin. The cmux pin bump is in a companion cmux PR.

Note: open #271 (split-action shortcuts in the collapsed menu) builds on the collapsed menu that this PR removes.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Restores the pane tab bar's full action button lane at narrow widths, reverting the recent collapse into a single ellipsis menu.

  • Panes narrower than 520pt now show every configured action button again, matching cmux 0.64.25.
  • Removes the narrow-pane collapse logic and its associated tests.
  • Show split action shortcuts in collapsed menu #271's split-action shortcuts build on the collapsed menu this PR removes, so that PR will need a rebase.

Written for commit 69cb13e. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Split-button actions now remain visible as individual buttons in narrow panes instead of collapsing into a single overflow button.
    • The tab bar layout now accounts for the full set of visible split-button actions, including when the pane is narrow.

Reverts 920b936 ("collapse tab actions in narrow panes") and its follow-up
b281035. Panes narrower than 520pt replaced the pane tab bar's individual
action buttons with a single ellipsis menu; the tab bar shows every
configured action button at any width again, as it did in cmux 0.64.25.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 21723222-052f-40db-bebe-121ef175d43b
📥 Commits

Reviewing files that changed from the base of the PR and between e52609f and 8bc81c8.

📒 Files selected for processing (3)
  • Sources/Bonsplit/Internal/Views/TabBarView.swift
  • Tests/BonsplitTests/BonsplitTests.swift
  • Tests/BonsplitTests/TabBarLayoutFeedbackTests.swift
 _______________________________________
< Your code's Big O notation: `O(WTF)`. >
 ---------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…abbar

# Conflicts:
#	Sources/Bonsplit/Internal/Views/TabBarView.swift
@austinywang
austinywang merged commit bddc73d into main Oct 5, 2026
4 checks passed
austinywang added a commit to manaflow-ai/cmux that referenced this pull request Oct 5, 2026
Bumps vendor/bonsplit to 8bc81c8 (manaflow-ai/bonsplit#273), which removes
the narrow-pane collapse that replaced the pane tab bar's action buttons
with a single ellipsis menu below 520pt. The pin moves forward from
64ac6d4 and does not include bonsplit#272.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant