Repository navigation
sign-in subtitle: lowercase cloud - #16691
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (2)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (19)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe sign-in and sign-up subtitles change “Cloud” to lowercase “cloud” in 19 locale message files. Sign-up titles remain unchanged. ChangesAuthentication localization
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The PR changes only sign-in and sign-up subtitle capitalization across 19 locales. Authentication behavior, keys, and titles remain unchanged, so no concrete merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merge receipt for |
467ae13 fix(cli): reject trailing auth arguments (manaflow-ai#15805) e3e237d sign-in subtitle: lowercase cloud (manaflow-ai#16691) 1b97a06 fix: route PR-media UI tours to GUI minis (manaflow-ai#16674) 841efd6 fix(port-scan): exclude identity-validated agent-root listeners (manaflow-ai#12435) df07e1d Merge pull request manaflow-ai#16668 from manaflow-ai/feat-ios-cloudvpn-resign 908c519 sign-in: email / email & password segmented control, "or continue with" divider (manaflow-ai#16673) 461b456 fix: avoid mutating affordance in expect arguments (manaflow-ai#16671) b415d22 Make browser page restore indicator unobtrusive (manaflow-ai#16667) 2ac5fae fix: keep beta exports independent of CloudVPN signing 047d7a2 fix: preserve CloudVPN packet tunnel entitlement b7613e9 test: require CloudVPN extension resigning
Summary
the sign-in and sign-up subtitle now reads "One account for the app, cloud and the dashboard." (was "Cloud"), in 19 of 20 catalogs. German keeps "Cloud" since it's a noun there and German capitalises nouns.
Testing
copy only, no test asserts the subtitle text. catalogs still parse with the same keys.
Changelog
none
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Lowercases "Cloud" in the sign-in and sign-up subtitles so they read "One account for the app, cloud and the dashboard" across 19 of 20 localization catalogs.
Written for commit 2badf4b. Summary will update on new commits.
Summary by CodeRabbit