Skip to content

sign-in subtitle: lowercase cloud - #16691

Merged
lucasr1b merged 1 commit into
mainfrom
sign-in-lowercase-cloud
Oct 2, 2026
Merged

lucasr1b merged 1 commit into
mainfrom
sign-in-lowercase-cloud

Conversation

@lucasr1b

@lucasr1b lucasr1b commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

the sign-in and sign-up subtitle now reads "One account for the app, cloud and the dashboard." (was "Cloud"), in 19 of 20 catalogs. German keeps "Cloud" since it's a noun there and German capitalises nouns.

Testing

copy only, no test asserts the subtitle text. catalogs still parse with the same keys.

Changelog

none

Checklist

  • UI, settings, menu, schema, help-text or user-facing docs change: localization audited, 19 catalogs updated, de left as is on purpose

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Lowercases "Cloud" in the sign-in and sign-up subtitles so they read "One account for the app, cloud and the dashboard" across 19 of 20 localization catalogs.

  • German keeps "Cloud" capitalized since German capitalizes nouns.
  • Copy-only change; no test asserts the subtitle text.

Written for commit 2badf4b. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Style
    • Standardized “Cloud” to lowercase “cloud” in sign-in and sign-up subtitles across supported languages.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (2)
.github/review-bot-rules/source-control-artifacts.md — configured
.github/review-bot-rules/landing-page-registry-parity.md — configured

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1fc0e883-db9f-437f-9820-110ce9f352c9

📥 Commits

Reviewing files that changed from the base of the PR and between df07e1d and 2badf4b.

📒 Files selected for processing (19)
  • web/messages/ar.json
  • web/messages/bs.json
  • web/messages/da.json
  • web/messages/en.json
  • web/messages/es.json
  • web/messages/fr.json
  • web/messages/it.json
  • web/messages/ja.json
  • web/messages/km.json
  • web/messages/ko.json
  • web/messages/no.json
  • web/messages/pl.json
  • web/messages/pt-BR.json
  • web/messages/ru.json
  • web/messages/th.json
  • web/messages/tr.json
  • web/messages/uk.json
  • web/messages/zh-CN.json
  • web/messages/zh-TW.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The sign-in and sign-up subtitles change “Cloud” to lowercase “cloud” in 19 locale message files. Sign-up titles remain unchanged.

Changes

Authentication localization

Layer / File(s) Summary
Authentication subtitle copy
web/messages/*.json
The sign-in and sign-up subtitles use lowercase “cloud” in the updated locales. Sign-up titles remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 2badf

The PR changes only sign-in and sign-up subtitle capitalization across 19 locales. Authentication behavior, keys, and titles remain unchanged, so no concrete merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 2badf

The change affects 1 system.

Changed systems: web

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — web (service) was modified; 19 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in web/messages/ar.json: Changed “Cloud” to lowercase “cloud” in the sign-in and sign-up subtitles; the account-creation title is unchanged.
  • observed — Modified behavior in web/messages/bs.json: The sign-in and sign-up subtitles change “Cloud” to “cloud”; the sign-up title is unchanged.
  • observed — Modified behavior in web/messages/da.json: cmuxSignIn.signInSubtitle og signUpSubtitle ændrer “Cloud” til “cloud”; signUpTitle er uændret.
  • observed — Modified behavior in web/messages/en.json: The sign-in and sign-up subtitles change “Cloud” to “cloud”; the sign-up title is unchanged.
🚥 Pre-merge checks | ✅ 25
✅ Passed checks (25 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: lowercasing “cloud” in the sign-in subtitle.
Description check ✅ Passed The description includes the required Summary, Testing, Changelog, and Checklist sections. It explains the 19-catalog localization change, the German exception, and test coverage. The Demo Video secti…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input ✅ Passed PASS: The pull request changes only 19 localization JSON files. Each change lowercases “Cloud” in cmuxSignIn.signInSubtitle and signUpSubtitle; no Cloud terminal creation, transport, session, inpu…
Cmux Swift Actor Isolation ✅ Passed The pull request changes only 19 JSON localization files under web/messages/. The scoped diff contains subtitle text replacements only and no Swift files or actor-isolation constructs. The Swift act…
Cmux Swift Blocking Runtime ✅ Passed PASS: The review-scoped diff changes only 19 JSON localization files. It contains no Swift or Swift-related file changes, and it introduces no semaphores, waits, sleeps, delayed dispatch, polling, mai…
Cmux Browser Automation Off-Main ✅ Passed PASS. The pull request changes only 19 localization JSON files. The diff changes sign-in and sign-up subtitle text from “Cloud” to “cloud.” It contains no browser automation, WebKit, socket-worker, ma…
Cmux Expensive Synchronous Load ✅ Passed PASS. The pull request changes only 19 JSON localization files under web/messages. The diff changes the capitalization of sign-in and sign-up subtitle text and adds no Swift code, agent-history loads,…
Cmux Cache Substitution Correctness ✅ Passed PASS — The reviewed diff changes only 19 localization JSON files. It contains text-only replacements of “Cloud” with “cloud” in sign-in and sign-up subtitles. No Swift, TypeScript, or JavaScript code …
Cmux No Hacky Sleeps ✅ Passed PASS: The PR changes only 19 JSON localization catalogs. The diff contains subtitle text replacements from “Cloud” to “cloud”; it adds no TypeScript, JavaScript, shell, build/runtime code, timers, sle…
Cmux Algorithmic Complexity ✅ Passed The pull request changes only 19 JSON localization files. The diff updates subtitle string values and adds no Swift, TypeScript, JavaScript, shell, runtime code, loops, scans, sorting, joins, or data-…
Cmux Swift Concurrency ✅ Passed The pull-request diff changes only 19 localization JSON files under web/messages. It contains no Swift files and introduces no async, Dispatch, Combine, completion-handler, or Task code. The Swift con…
Cmux Swift @Concurrent ✅ Passed PASS: The authoritative PR diff changes only 19 JSON localization files under web/messages/. It contains no Swift files, async functions, actor isolation, or @concurrent changes. The Swift concurr…
Cmux Swift Package Boundaries ✅ Passed PASS: The review-scoped diff changes only 19 localization JSON files under web/messages/. It contains no Swift production changes, so the Swift package boundary rule does not apply.
Cmux Swiftpm Lockfiles ✅ Passed PASS: The review-scoped diff changes only 19 web/messages/*.json localization files. It contains no SwiftPM package, Xcode project, .gitignore, workflow, or dependency changes, so the SwiftPM lock…
Cmux Swift Logging ✅ Passed The review-scoped diff changes only 19 localization JSON files. It changes the sign-in and sign-up subtitle text from “Cloud” to “cloud” and adds no Swift code or logging calls. The Swift logging chec…
Cmux User-Facing Error Privacy ✅ Passed PASS — The PR changes only sign-in and sign-up subtitles in 19 locale JSON files, replacing “Cloud” with the generic term “cloud.” The text reaches users through web/app/handler/[...stack]/page.tsx …
Cmux Full Internationalization ✅ Passed PASS. The PR changes only the two cmuxSignIn subtitle entries in 19 locale files. web/i18n/routing.ts lists 20 locales, and all 20 corresponding message files contain both keys. The unchanged Germ…
Cmux Swiftui State Layout ✅ Passed PASS: The authoritative PR diff changes only 19 localization JSON files under web/messages. It updates subtitle text from Cloud to cloud and contains no SwiftUI code, ObservableObject, `@Publi…
Cmux Architecture Rethink ✅ Passed PASS: The pull request changes only 19 JSON localization files. The diff updates the sign-in and sign-up subtitle text from “Cloud” to “cloud”. It contains no Swift files and no architectural changes …
Cmux Swift Auxiliary Window Close Shortcuts ✅ Passed PASS. The pull request changes only 19 localization JSON files. The authoritative diff contains no Swift files and no NSWindow, NSPanel, window controller, SwiftUI Window, or WindowGroup changes. The …
Cmux Source Artifacts ✅ Passed All 19 changed paths are intentional localization catalogs under web/messages/, which the rule explicitly allows. The diff only changes signInSubtitle and signUpSubtitle text from Cloud to `cl…
Cmux No Test Or Debug Seam In Production Source ✅ Passed PASS: The pull request changes only 19 localization JSON files under web/messages/. It contains no changed Swift file under a production Sources/ path, so it cannot introduce a test or debug seam …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lucasr1b
lucasr1b merged commit e3e237d into main Oct 2, 2026
70 of 71 checks passed
@lucasr1b
lucasr1b deleted the sign-in-lowercase-cloud branch October 2, 2026 04:57
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Merge receipt for 2badf4b033: every check was green at merge (19 verified; 18 skipped by policy). Full suite runs on main after merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Oct 2, 2026
467ae13 fix(cli): reject trailing auth arguments (manaflow-ai#15805)
e3e237d sign-in subtitle: lowercase cloud (manaflow-ai#16691)
1b97a06 fix: route PR-media UI tours to GUI minis (manaflow-ai#16674)
841efd6 fix(port-scan): exclude identity-validated agent-root listeners (manaflow-ai#12435)
df07e1d Merge pull request manaflow-ai#16668 from manaflow-ai/feat-ios-cloudvpn-resign
908c519 sign-in: email / email & password segmented control, "or continue with" divider (manaflow-ai#16673)
461b456 fix: avoid mutating affordance in expect arguments (manaflow-ai#16671)
b415d22 Make browser page restore indicator unobtrusive (manaflow-ai#16667)
2ac5fae fix: keep beta exports independent of CloudVPN signing
047d7a2 fix: preserve CloudVPN packet tunnel entitlement
b7613e9 test: require CloudVPN extension resigning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant