Skip to content

Restore real custom sidebar template previews - #16535

Merged
teamleaderleo merged 1 commit into
mainfrom
feat/sidebar-real-previews
Oct 1, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
feat/sidebar-real-previews

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Restores the custom sidebar template gallery after the stopgap in #16518 removed generated placeholder art. The gallery is wired for six real light and dark captures at the exact asset size; captures will be added to this branch from a fleet-built cmux session.

Also corrects the agents-board.js install comment to use the left-sidebar command registered by its manifest.

Validation

  • All six template headers checked against manifest.json; left/right install commands match.
  • Real capture work is being performed on a managed Mac mini fleet worker.

Before / after

Before: generated placeholder cards from #15931 (removed by #16518).

After: real cmux sidebar captures will be attached here once captured.

Historical asset audit

Pending audit of committed preview/screenshot PNGs added by teamleaderleo since 2026-09-17. Any other generated assets will be listed here and are intentionally out of scope.

— Saffron g2 🪁


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Restores the custom sidebar template gallery to show real light and dark preview captures instead of the placeholder art that was removed. Preview images are bundled per template and matched to the current system appearance.

Also fixes the agents-board.js install comment to use the cmux sidebar set command registered by its manifest.

Written for commit fa1d9c2. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo enabled auto-merge (squash) October 1, 2026 23:13
@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b1db564b-253a-48a5-b07b-e0991f3183f4

📥 Commits

Reviewing files that changed from the base of the PR and between 343dd1b and fa1d9c2.

📒 Files selected for processing (4)
  • Packages/macOS/CmuxSettings/Sources/CmuxSettings/Resources/CustomSidebarTemplates/agents-board.js
  • Packages/macOS/CmuxSettingsUI/Package.swift
  • Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/CustomSidebarOnboardingAssets.swift
  • Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Sections/CustomSidebarsSection.swift
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamleaderleo
teamleaderleo merged commit 11bfe00 into main Oct 1, 2026
21 of 22 checks passed
@teamleaderleo
teamleaderleo deleted the feat/sidebar-real-previews branch October 1, 2026 23:13
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Merge receipt for fa1d9c2894, merged 2026-10-01 23:13:49 UTC

  • Not verified at merge: ci-status (not reported), CI fast guards (in progress), detect-ios-changes (in progress), Fast static checks (in progress), Web complexity (in progress)
  • Verified: runner, web-validation
  • Skipped by policy: web-build, web-database-tests, web-tests
  • Full suite: runs on main after merge.

Labeled merged-unverified: if main breaks near this merge, look here first.

@github-actions github-actions Bot added the merged-unverified A judging check was not green at merge; see the merge receipt comment label Oct 1, 2026
rustybret pushed a commit to rustybret/bmux that referenced this pull request Oct 1, 2026
0906bcb fix: make main's full test suite pass again (manaflow-ai#16429)
11bfe00 Restore custom sidebar preview gallery (manaflow-ai#16535)
343dd1b web: sync all Hexclave webhooks into a validated, order-independent mirror (manaflow-ai#16339)
00547d5 ci: avoid blaming unrelated merges for compile failures (manaflow-ai#16533)
b782440 fix(ci): provision Go for every iOS Release archive (manaflow-ai#16534)
3555618 Add a Jump to Bottom button to terminal panes (manaflow-ai#15382)
79febcf fix: tolerate delayed App Store Connect processing (manaflow-ai#16527)
fcbf13c fix: export Foundation for remote paste policy (manaflow-ai#16525)
6d86537 Add What's New recap with an off / quiet / sheet setting (manaflow-ai#14876)
256d964 fix(xcstrings): keep conflict resolutions valid JSON (manaflow-ai#16071)
8473bdc fix: upload pasted images into private SSH directories (manaflow-ai#16523)
53c705c Show opt-in model, context %, and estimated cost next to agent status in the sidebar (manaflow-ai#14855)
eba3c42 remote relay: permit scoped terminal paste (manaflow-ai#14915)
e447665 fix: stop update relaunch prompts from looping (manaflow-ai#15702)
4a46320 Fix Cloud paid team limits for ID-only selected teams (manaflow-ai#16318)
c266af9 test(cloud): pin the CLI tree's link error message through the bundled CLI (manaflow-ai#16515)
0059066 Calmer focus feedback: one short pulse, no flash while typing (manaflow-ai#14894)
65930fc fix(remote): preserve tmux split metadata (manaflow-ai#16398)
512817d docs: fill missing unreleased user-facing changes (manaflow-ai#16519)
f204ade ci: nightly 120 Hz fling bench for the cmux-next agent pane (manaflow-ai#16511)
2be3b26 Remove generated custom sidebar preview art (manaflow-ai#16518)
teamleaderleo added a commit that referenced this pull request Oct 2, 2026
…preview generator (#16595)

* fix(sidebars): make both agents-board copies name a real command

#16535 changed the bundled copy's install comment to `cmux sidebar set custom`
and #16569 changed the Examples copy to `cmux left-sidebar set custom`, so
bundledManifestMatchesExamplesFolder failed. Neither command exists; use
`cmux sidebar open agents-board`, which the Examples README documents.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(cloud): assert the machine name's truncation mode without NSTextField

The row renders its name with SwiftUI Text, which AppKit does not back with
an NSTextField, so the test added in #16202 could never find a field. Expose
the truncation mode the view applies and assert it directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(sidebars): drop the mockup preview generator

#16569 replaced the generated mockup cards with real captures; running the
generator would overwrite them with mockups again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-unverified A judging check was not green at merge; see the merge receipt comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant