Skip to content

fix(settings): tolerate missing custom sidebar previews - #16545

Merged
teamleaderleo merged 1 commit into
mainfrom
fix/settings-optional-preview
Oct 2, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
fix/settings-optional-preview

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

The settings package declares Resources/CustomSidebarTemplatePreviews as a copied resource, but current main no longer carries that generated directory after preview art was removed. Every macOS package compile then fails before feature-specific tests run.

Remove the resource declaration. CustomSidebarOnboardingAssets already returns an optional URL, so the settings UI continues to work without bundled previews.

Validated with git diff --check; hosted package and app-host compilation should verify the resource graph.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes macOS package compilation by removing the resource declaration for CustomSidebarTemplatePreviews, a generated directory that no longer exists after preview art was removed.

  • The settings UI is unaffected: CustomSidebarOnboardingAssets already returns an optional URL, so it works without bundled previews.

Written for commit 0569dcf. Summary will update on new commits.

Review in cubic

@cursor

cursor Bot commented Oct 1, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b242227e-24c7-4ac5-beaf-c8133cb4540e

📥 Commits

Reviewing files that changed from the base of the PR and between 30226ce and 0569dcf.

📒 Files selected for processing (1)
  • Packages/macOS/CmuxSettingsUI/Package.swift
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Subagent review at 0569dcf: approve. Main has no Resources/CustomSidebarTemplatePreviews, because #16518 deleted it and #16535 re-added only the .copy, so main fails with exit 65. previewImageURL returns URL?, and its only caller (CustomSidebarsSection.swift:352) renders inside if let. No test or project reference depends on the folder. Non-blocking: docs/custom-sidebars.md, Examples/CustomSidebars/README.md and scripts/generate-sidebar-template-previews.py still point at the missing PNGs. The captures PR should restore the .copy together with the images.

@teamleaderleo
teamleaderleo merged commit 8b8762a into main Oct 2, 2026
72 of 73 checks passed
@teamleaderleo
teamleaderleo deleted the fix/settings-optional-preview branch October 2, 2026 00:04
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Merge receipt for 0569dcfcd4: every check was green at merge (19 verified; 21 skipped by policy). Full suite runs on main after merge.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Dogfood tours of 0569dcfc

conversations-sidebar-tour at 0569dcfc: not run

skipped: CI built this head on a runner pool whose products the UI test Macs cannot load, and media never compiles one; gh workflow run pr-media.yml -f pr=<n> -f allow_compile=true does

Tours are picked by the paths globs in dogfood/scenarios/*.json; a Dogfood-tours: a, b line in the description picks them instead (none turns this off). Look at every frame before merging: a green tour only means no step failed.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Oct 2, 2026
8b8762a fix(settings): tolerate missing custom sidebar previews (manaflow-ai#16545)
30226ce fix: repair main's app compile (manaflow-ai#16523 SSH paste quoting + upload path, manaflow-ai#14855 optional chain) (manaflow-ai#16531)
1440e29 Add secure one-time CodeRouter handoff leases (manaflow-ai#10118)
77fd1d5 test(sidebar): resolve a committed conflict marker, keeping both tests (manaflow-ai#16540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant