Skip to content

fix: tolerate delayed App Store Connect processing - #16527

Merged
azooz2003-bit merged 2 commits into
mainfrom
feat-ios-testflight-processing-timeout
Oct 1, 2026
Merged

azooz2003-bit merged 2 commits into
mainfrom
feat-ios-testflight-processing-timeout

Conversation

@azooz2003-bit

@azooz2003-bit azooz2003-bit commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Increase App Store Connect build ingestion waits from 15 minutes to 30 minutes for internal assignment and TestFlight notes.
  • Keep the notes job alive for the full wait window.
  • Add regression coverage for the shared processing timeout.

Changelog

Fixed official cmux.app TestFlight uploads timing out while Apple is still processing an accepted build.

Validation

  • PYTHONPATH=tests python3 - <<'PY' ... test_processing_wait_defaults_cover_apple_ingest() ... PY
  • bash -n ios/scripts/set-testflight-notes.sh
  • python3 -m py_compile ios/scripts/asc_assign_internal_testflight_group.py ios/scripts/asc_set_testflight_notes.py
  • git diff --check

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes official cmux.app TestFlight uploads timing out while Apple is still processing an accepted build.

  • Increases the default App Store Connect ingestion wait from 15 to 30 minutes for internal assignment and TestFlight notes.
  • Keeps the notes job alive for the full wait window and adds regression coverage.
  • Makes the shell notes timeout overridable via CMUX_TESTFLIGHT_PROCESSING_TIMEOUT_SECONDS.

Written for commit 55159a2. Summary will update on new commits.

Review in cubic

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@azooz2003-bit
azooz2003-bit enabled auto-merge (squash) October 1, 2026 22:39
@azooz2003-bit
azooz2003-bit merged commit 79febcf into main Oct 1, 2026
45 of 47 checks passed
@azooz2003-bit
azooz2003-bit deleted the feat-ios-testflight-processing-timeout branch October 1, 2026 22:39
@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 83469e69-be33-409a-9b2e-815cc5f156b4

📥 Commits

Reviewing files that changed from the base of the PR and between fcbf13c and 55159a2.

📒 Files selected for processing (5)
  • .github/workflows/ios-appstore-upload.yml
  • ios/scripts/asc_assign_internal_testflight_group.py
  • ios/scripts/asc_set_testflight_notes.py
  • ios/scripts/set-testflight-notes.sh
  • tests/test_ios_testflight_notes.py
 _________________________________________________________________________________________________
< Question: How does a large software project get to be one year late? Answer: One day at a time! >
 -------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Merge receipt for 55159a2de6, merged 2026-10-01 22:39:33 UTC

  • Not verified at merge: ci-status (not reported), CI fast guards (in progress), detect-ios-changes (in progress), Fast static checks (in progress), GhosttyKit release check (in progress), guards (4) (in progress), Web complexity (in progress)
  • Verified: runner, web-validation
  • Skipped by policy: browser, Dogfood build #​${{ github.event.pull_request.number }}, full-suite-coverage, suite-coverage, web, web-build, web-database-tests, web-tests
  • Full suite: runs on main after merge.

Labeled merged-unverified: if main breaks near this merge, look here first.

@github-actions github-actions Bot added the merged-unverified A judging check was not green at merge; see the merge receipt comment label Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

main no longer compiles after this merge

@azooz2003-bit: after 79febcf342 landed on main, the app-host test product (the app and cmuxTests, build-for-testing) stops compiling. These errors first show up in a range of 1 merges (fcbf13cda8..79febcf342), and this pull request's diff is the one that reaches them. The other merges in that range () are being compiled on their own to confirm.

Evidence: https://github.com/manaflow-ai/cmux/actions/runs/36936384119/job/110617739862

Sources/TerminalSSHSessionDetector.swift:208: error: 'shellSingleQuoted' is inaccessible due to 'internal' protection level
Sources/TerminalSSHSessionDetector.swift:212: error: cannot infer contextual base in reference to member 'whitespacesAndNewlines'

Nothing blocks merging meanwhile. A fix-forward (or, failing that, a revert) is attempted automatically unless an open pull request already fixes this.

main_compile_attribution.py: post-merge, nothing here gates a merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Oct 1, 2026
0906bcb fix: make main's full test suite pass again (manaflow-ai#16429)
11bfe00 Restore custom sidebar preview gallery (manaflow-ai#16535)
343dd1b web: sync all Hexclave webhooks into a validated, order-independent mirror (manaflow-ai#16339)
00547d5 ci: avoid blaming unrelated merges for compile failures (manaflow-ai#16533)
b782440 fix(ci): provision Go for every iOS Release archive (manaflow-ai#16534)
3555618 Add a Jump to Bottom button to terminal panes (manaflow-ai#15382)
79febcf fix: tolerate delayed App Store Connect processing (manaflow-ai#16527)
fcbf13c fix: export Foundation for remote paste policy (manaflow-ai#16525)
6d86537 Add What's New recap with an off / quiet / sheet setting (manaflow-ai#14876)
256d964 fix(xcstrings): keep conflict resolutions valid JSON (manaflow-ai#16071)
8473bdc fix: upload pasted images into private SSH directories (manaflow-ai#16523)
53c705c Show opt-in model, context %, and estimated cost next to agent status in the sidebar (manaflow-ai#14855)
eba3c42 remote relay: permit scoped terminal paste (manaflow-ai#14915)
e447665 fix: stop update relaunch prompts from looping (manaflow-ai#15702)
4a46320 Fix Cloud paid team limits for ID-only selected teams (manaflow-ai#16318)
c266af9 test(cloud): pin the CLI tree's link error message through the bundled CLI (manaflow-ai#16515)
0059066 Calmer focus feedback: one short pulse, no flash while typing (manaflow-ai#14894)
65930fc fix(remote): preserve tmux split metadata (manaflow-ai#16398)
512817d docs: fill missing unreleased user-facing changes (manaflow-ai#16519)
f204ade ci: nightly 120 Hz fling bench for the cmux-next agent pane (manaflow-ai#16511)
2be3b26 Remove generated custom sidebar preview art (manaflow-ai#16518)
@teamleaderleo

Copy link
Copy Markdown
Collaborator

Correction to the compile note above: this PR didn't break main. It only touches the iOS TestFlight scripts. The break came from #16523 (SSH image paste), which used a string helper that's internal to another package. #16531 fixed it, and #16533 fixed the attribution so it no longer blames the first PR in the red range. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-unverified A judging check was not green at merge; see the merge receipt comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants