Repository navigation
docs: tell contributors to start after claiming and not wait on app-host tests - #15941
Conversation
…ost tests Contributors were claiming help-wanted issues and waiting for a go-ahead, and one stepped back because they could not run the app-host tests locally. Start here now says to start right after claiming, to skip `needs a call` issues, and that CI runs the app-host suites. CONTRIBUTING.md is cut to the mechanics, with the review and PR-quality prose it duplicated left in start-here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
CI failure attributionCI passes on Written by |
Dogfood tours of
|
|
/catch-up |
|
The merge with Catch-up run · RFC #14631 |
|
Red here is not this PR's fault. This branch pins
— Raindrop g2 🫧 / Run: run_worker_20260930_3fc64ba6 |
|
/catch-up My earlier catch-up comment on this PR did nothing: I wrapped the command in backticks, and the gate is — Raindrop g2 🫧 / Run: run_worker_20260930_3fc64ba6 |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The rewrite dropped why `biome check .` is scoped and the standing constraint that it must not become a required CI check while formatting and import sorting are off. Everything else the rewrite moved landed in docs/start-here.md, but this note had no new home, so it is back beside the command. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Review: land. I checked what the rewrite dropped rather than what it reads like, since a 174-line deletion in a contributor entry point is mostly a question of where things went. Re-homed correctly, verified in the new tree: the review-and-merge sequence, squash merges and fix-forward are in Fixed: one item had no new home. The rewrite dropped why Left, worth knowing but not worth holding docs on: Merging on green. — Raindrop g2 🫧 |
|
Merge receipt for
Labeled |
579a979 Align Cloud machine stale status punctuation (manaflow-ai#16228) c7d37b6 Merge pull request manaflow-ai#15806 from manaflow-ai/feat-team-settings-minimal a62dacc docs: tell contributors to start after claiming and not wait on app-host tests (manaflow-ai#15941) 7befdc7 Fix Cloud notification pane attribution (manaflow-ai#15972) 071e912 fix(ios): prevent computer picker status clipping (manaflow-ai#15799) 20cd45f Merge remote-tracking branch 'origin/main' into feat-team-settings-minimal 1ad9de2 Fix Cloud reconcile for membership-less previews (manaflow-ai#16109) a4c7eda Make new windows honor configured sidebar width (manaflow-ai#11539) d1c9a6f Merge pull request manaflow-ai#16219 from manaflow-ai/feat-team-invites-app ad16812 Fix Cloud sidebar parity after individual notification reads (manaflow-ai#15933) 285dbf7 Add live physical iOS IRX log viewer (manaflow-ai#12008) cce8214 Fix blank terminal surface after completion notification (manaflow-ai#11954) a4e862d Keep Codex auto-naming credentials out of argv (manaflow-ai#16201) f14e824 Merge remote-tracking branch 'origin/main' into feat-team-invites-app 4b832ea fix: honor OpenCode XDG and database path overrides (manaflow-ai#16229) 633852a Merge remote-tracking branch 'origin/main' into feat-team-invites-app ff131f9 Merge remote-tracking branch 'origin/main' into feat-team-invites-app 0bf5223 Merge remote-tracking branch 'origin/main' into feat-team-invites-app f221acb Merge remote-tracking branch 'origin/main' into feat-team-invites-app 7037871 Merge remote-tracking branch 'origin/main' into feat-team-invites-app 97395db Merge origin/main into feat-team-invites-app 4443dc1 cloud: header keeps only the team row and Invite after main's layout change 8e8839c Merge origin/main into feat-team-invites-app 77c068a ci: re-trigger pull request checks ac5842e cloud: received-invitation reads wait for the teams client bootstrap 04ce3d1 vendor/bonsplit: follow main's pointer 6d33293 Merge origin/main into feat-team-invites-app aea3cf4 Merge origin/feat-dashboard-tanstack into feat-team-invites-app 0c0f4dc web: invite email strips control characters from names and carries no token-derived header e775fee settings: the Invitations card loads from a zero-size anchor e1d3272 Merge origin/feat-dashboard-tanstack into feat-team-invites-app 282354c socket: register the received-invitation methods with the capability list and execution policy 9b95924 web tests: team detail seeds an email invitation row 7b2979e cloud: received invitations in Settings, the team menu, notifications, the socket and the CLI 548d240 web: cmux sends team invitation emails through Resend and serves received invitations 3f12b3e settings: Members card strings resolve from the package bundle ed80608 Merge branch 'feat-team-invites-app' into feat-team-settings-minimal 76c7093 cloud: the seats-open line uses the localized formatter 722fabb Merge branch 'feat-team-invites-app' into feat-team-settings-minimal c2b5afd cloud: nonisolated socket method table; plural seats line uses the localized formatter 5a7939c settings: format plural team strings with the localized formatter 3e3e486 Merge branch 'feat-team-invites-app' into feat-team-settings-minimal 532e318 tests: header height helper drops the removed refresh and agent menu arguments a373523 settings: plain Members card with per-row progress 550a580 web tests: carry every real stack export in dashboard mocks; drop the no-op mock restore 8d8af37 web: carry memberLimit and seat_limit into the oRPC team contract; teams-routes restores its module mocks 94f4aba Merge remote-tracking branch 'origin/feat-dashboard-tanstack' into feat-team-invites-app 688eb31 cloud: team chip uses the tab bar grey 7549cd4 cloud: Invite label uses the tab bar grey and ends under the close glyph c2d1d39 cloud: no seat-check loading line, quiet Invite button, header aligned with the tree 1020ab9 Merge origin/feat-dashboard-tanstack into feat-team-invites-app 7d9bbc2 cloud: header keeps only Invite; empty section offers New Machine 5c2fd03 cloud: Invite is a popover on the header button; Revoke is a real button 8b35736 cloud: invite sheet fits its content; link button never wraps 2df3a09 cloud: invite sheet is a plain form 0e25775 cloud: redesign the invite sheet 4660c0a cloud: invite sheet height fits its content ea905ca cloud: invite sheet is a fixed-size hosting view, not a preferred-size controller 5bffd69 cloud: invite sheet uses a single-line email field so the sheet can open d3b6e85 cloud: a dedicated invite sheet explains what a member gets 5f657ae tests: seat queue SQL contract behind CMUX_DB_TEST 06f4a7c teams: seats follow membership in the docs and UI copy 3a1790a billing: Team seat quantity follows the member count 7579097 cloud header: Invite and New Machine buttons, refresh and agent launchers in an overflow menu 93c06da l10n: keep main's text for untouched keys 1ef0878 settings: team members and invites live in Settings › Account 5f7699e cli: team roster verbs wait 60s for the network round trip d4aef24 web: log the Stack error class behind a failed team request fee9821 web: log why a team invitation send failed 6c53598 auth: team member error mapping is nonisolated for the socket path 149993d test: synthetic team origin requests use a test host 3428fa8 test: team detail billing summary includes memberLimit 6b58941 app: the team members window owns the standard close shortcut 808c9f9 l10n: keep main's catalog order; append the team members keys 0c4553a Merge origin/main into feat-team-invites-app 13f72e9 xcodeproj: add CloudTeamMembersWindow and HostAccountFlow+TeamMembers to the app target adda7a2 test: new auth.team socket methods run on the socket worker e78d62d socket: hoist async roster reads out of argument lists c763126 swift: hoist path encoding out of interpolation; focus invite field only on request 0c344bf l10n: team members and invites strings in all nine locales 6eaa946 wip: swift team invites and members (pre-localization) 1c45713 web: cap Pro and Max personal teams at 3 members
Summary
Contributors have been claiming
help wantedissues and then waiting for a go-ahead that never comes (#15710, #15743, #15755 got no reply), and one stepped back from #15752 because they couldn't run the app-host tests locally. Nothing in the entry docs said either was fine.docs/start-here.md: claim with one comment, then start; no need to wait for a reply. Skip issues labeledneeds a call. Say so on the issue if you stop. Don't let app-host or UI tests block the PR, since CI runs the app-host suites your diff touches. Notes that the CLA check matches commit emails (fix(cli): reject trailing auth arguments #15805 is stuck on that). Picks up the squash-merge and fix-forward notes from CONTRIBUTING.CONTRIBUTING.md: cut to the mechanics (274 lines changed, about 90 shorter). Setup is one code block plus notes; "Running Tests" and "What CI runs for you" are one section with the app-host note up front; the PR section is one checklist. The "what a good PR looks like" and "how review works" prose it duplicated from start-here is gone, with a link. Every anchor other docs link to (#getting-started,#fast-checks-before-building-or-pushing) is kept.docs/contributor-verification.md: a missing local app-host run isn't a reason to hold back the PR..github/contributor/welcome.md: the same note in the first-PR welcome.Testing
python3 scripts/verify-local.py --affected upstream/main: 15/15 selected checks passed.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Clarifies the contributor docs so new contributors start working as soon as they claim a
help wantedissue instead of waiting for a reply that never comes, and so missing local app-host tests no longer block a pull request.needs a call.CONTRIBUTING.mdto the mechanics and removes the review and PR-quality prose it duplicated fromstart-here.md, keeping thebiome check .scoping note and anchors other docs link to.Written for commit 04483d9. Summary will update on new commits.