Repository navigation
test: fix three app-host tests that keep main red - #15204
Conversation
#15123 removed the Cloud tree's reorder insertion line on purpose and updated CloudSidebarNativeDropTests, but CloudMachineOrderingTests still required the sidebarReorderIndicator view, so every case failed. Assert that no indicator is drawn and keep the move, order, pin, selection and expansion checks. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The CLI reads its socket password file under homeDirectoryForCurrentUser, which follows CFFIXED_USER_HOME rather than HOME. On a runner whose own cmux set a socket password, the CLI sent auth first and printed the fake responder's canned error verbatim, so events.stream was never requested and both tests failed. Use BundledCLITestSupport.hermeticCLIEnvironment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Since the Reduce Transparency support, the terminal mount resolves the opaque window fill and removes any glass root when the system setting is on, so browserAndTerminalRespectChrome(useGlass: true) failed on hosts with it enabled. Install and expect the glass root only when the app would keep it; the portal hit-testing checks still run everywhere. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Dogfood build of cmux DEV pr-15204-e132dff3.app The link opens this exact commit in the cmux dev menu bar app. The build starts on each push and the page waits until it is ready; a newer push replaces it. It signs in against production, so Cloud or backend changes still need a tagged build with a development backend. |
CI failure attributionCI failed on
Matched log linesEvery failure is a machine failure: re-ran the failed jobs as attempt 2 (the checks show its result). Written by |
|
Merge receipt for |
ba94a13 CI: let Iroh release gate reuse unchanged TUI artifact 71a921c fix(web): stop orphaned Cloud VM alert pages (manaflow-ai#15138) 9971c2c Keep newer iOS connections alive when a recovery is superseded (manaflow-ai#15141) c307ab0 cmux-tui: only connect to derived local sockets served by this user (manaflow-ai#15144) 1220252 codex-teams: keep the watcher's socket password out of its arguments (manaflow-ai#15140) b3a73f0 chatmux-relay: keep cmux-tui sockets and journal cursors private to this user (manaflow-ai#15156) b0d5083 ci: dispatch UI tests from a default-branch workflow; PR CI keeps no write token (manaflow-ai#15226) 1255448 test: fix three app-host tests that keep main red (manaflow-ai#15204) 0fc4975 test: pin the fixture PATH inside the zsh watcher sleep test (manaflow-ai#15237) 758aaeb fix(ios): clear read notifications on foreground return (manaflow-ai#14725) 4c15bb3 cmux-browser: stop requiring GPL for web/package.json (manaflow-ai#15231) 97fe6b4 test: keep the Cloud notification harness workspace unselected (manaflow-ai#15215) 61083e3 test: keep workspace cwd inheritance tests off the shared standard defaults (manaflow-ai#15227) eae4994 Pin password badge actions to their source runtime (manaflow-ai#14921) fd96369 Check the owner of the Claude shim directory in the app, workspace commands and nushell (manaflow-ai#15185) 0ebf8d7 Fix main-thread freeze during SSH paste detection (manaflow-ai#15113) a98c560 test: pin font magnification in the Cloud outline attention test (manaflow-ai#15213)
1 participant
Summary
Three app-host tests that keep
main's full suite red, each fixed at its cause. All three are test-only.CloudMachineOrderingTests(fails every case). Keep Cloud sidebar drags free of hints #15123 removed the Cloud tree's reorder insertion line on purpose and updatedCloudSidebarNativeDropTests, but this suite still required thesidebarReorderIndicatorview. The tests now assert that no indicator is drawn. The move, order, pin, selection and expansion checks are unchanged. Failed in main run 36379348668.CMUXCLIEventsStreamErrorTests(fails on runners whose own cmux set a socket password). The CLI reads its socket password file underhomeDirectoryForCurrentUser, which followsCFFIXED_USER_HOME, notHOME. When that file exists, the CLI sendsauthfirst and prints the fake responder's canned error verbatim, soevents.streamis never requested. Both tests now spawn the CLI withBundledCLITestSupport.hermeticCLIEnvironment. Failed on all 3 attempts in main run 36373808820.WindowOverlayChromeTests/browserAndTerminalRespectChrome(useGlass: true)(fails on some hosted runners). The likely cause is the system Reduce Transparency setting on those hosts: since the Reduce Transparency support landed, mounting the terminal resolves the opaque window fill and removes any glass root when the system setting is on. The test now installs and expects the glass root only when the app would keep it. The portal hit-testing checks still run on every host. Failed in main runs 36341390537 and 36379348668.Testing
Changelog
none
🤖 Generated with Claude Code