Repository navigation
ci: give each Python lane test an empty Foundation home - #15289
Conversation
The cmux CLI reads its socket password file under Foundation's home directory, which follows CFFIXED_USER_HOME rather than HOME. On a runner whose account also runs cmux with a socket password, every CLI test that talks to a fake socket got an `auth` line first and failed (11 tests in one main run's app-host shard 4). Point CFFIXED_USER_HOME at an empty per-test directory unless the job or test already sets it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
Warning Review limit reachedNext included review available in 8 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Dogfood build of cmux DEV pr-15289-f6c70573.app The link opens this exact commit in the cmux dev menu bar app. The build starts on each push and the page waits until it is ready; a newer push replaces it. It signs in against production, so Cloud or backend changes still need a tagged build with a development backend. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Merge receipt for |
0c753fe ci: give each Python lane test an empty Foundation home (manaflow-ai#15289) 62cde14 Place config error notice below the tab bar (manaflow-ai#15218) 436909b Keep an exited terminal's tab edge consistent with its revision (manaflow-ai#15205) fc882fe Cloud: rebake the devbox ladder with cmux-tui 3412812 (manaflow-ai#15323) 8e6357b Add pr-media.py for putting a clip or screenshot on a PR (manaflow-ai#15295) 1755ea8 ci: place release-build and main's side lanes on the owned minis (manaflow-ai#14797) 447eb04 Keep focused-pane notifications silent unless opted in (manaflow-ai#15233) f66d18a Dial every discovered Mac concurrently on iOS (manaflow-ai#15127) dc5a21a ci: place the Iroh release gate's Tailscale job on the owned minis (manaflow-ai#15139) 3887653 docs: hide the Cloud beta note on nightly docs (manaflow-ai#15317) f4115d7 Center cloud row icon glyphs by their visible pixels (manaflow-ai#15149) 8714160 Let dogfood tours hold modifiers while clicking (manaflow-ai#15239) # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/ci-owned-pool-rescue.yml # .github/workflows/ci.yml # .github/workflows/iroh-release-gate.yml # .github/workflows/remote-daemon.yml
Summary
In main run 36398180780, app-host shard 4 failed 11 Python lane tests on one owned runner. Among them were
test_cli_socket_operation_deadline,test_cli_layout_focus_contract,test_browser_profile_cliand thetest_cli_claude_teams_*tests. Their fake sockets received a line that was not JSON, or closed before replying.The cmux CLI reads its socket password file under Foundation's home directory, and that directory follows
CFFIXED_USER_HOME, notHOME. When the runner account also runs its own cmux with a socket password, the CLI sendsauth <password>to every fake socket before the request under test. #15204 fixed the same failure in the SwiftCMUXCLIEventsStreamErrorTestson the same runner.run_python_test_lane.pynow pointsCFFIXED_USER_HOMEat an empty per-test directory, unless the job or the test already sets it. Tests that set their own isolated home are unchanged.Testing
run_oneon a stub test locally: it receives a fresh per-testCFFIXED_USER_HOME.python3 -m py_compile scripts/ci/run_python_test_lane.py.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes flaky Python lane tests on runners whose account also runs its own cmux.
CFFIXED_USER_HOME(notHOME), sending anauthline to every fake socket fixture before the request under test, which broke 11 tests in one main run.run_python_test_lane.pynow pointsCFFIXED_USER_HOMEat an empty per-test directory unless the job already sets it; tests may still set their own isolated home for subprocesses.Written for commit f6c7057. Summary will update on new commits.