Repository navigation
test: pin the fixture PATH inside the zsh watcher sleep test - #15237
Conversation
test_issue_15066_zsh_watcher_sleep's fallback check found no call to the fixture's fake sleep on a hosted macOS runner, although the fallback ran. zsh reads /etc/zshenv even with -f, so a host whose /etc/zshenv reorders PATH resolves sleep to /bin/sleep. Restore the fixture PATH at the start of every zsh command, and print the resolved sleep and the shell output if the fallback check still fails. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Dogfood build of cmux DEV pr-15237-35cd134f.app The link opens this exact commit in the cmux dev menu bar app. The build starts on each push and the page waits until it is ready; a newer push replaces it. It signs in against production, so Cloud or backend changes still need a tagged build with a development backend. |
|
Merge receipt for
|
ba94a13 CI: let Iroh release gate reuse unchanged TUI artifact 71a921c fix(web): stop orphaned Cloud VM alert pages (manaflow-ai#15138) 9971c2c Keep newer iOS connections alive when a recovery is superseded (manaflow-ai#15141) c307ab0 cmux-tui: only connect to derived local sockets served by this user (manaflow-ai#15144) 1220252 codex-teams: keep the watcher's socket password out of its arguments (manaflow-ai#15140) b3a73f0 chatmux-relay: keep cmux-tui sockets and journal cursors private to this user (manaflow-ai#15156) b0d5083 ci: dispatch UI tests from a default-branch workflow; PR CI keeps no write token (manaflow-ai#15226) 1255448 test: fix three app-host tests that keep main red (manaflow-ai#15204) 0fc4975 test: pin the fixture PATH inside the zsh watcher sleep test (manaflow-ai#15237) 758aaeb fix(ios): clear read notifications on foreground return (manaflow-ai#14725) 4c15bb3 cmux-browser: stop requiring GPL for web/package.json (manaflow-ai#15231) 97fe6b4 test: keep the Cloud notification harness workspace unselected (manaflow-ai#15215) 61083e3 test: keep workspace cwd inheritance tests off the shared standard defaults (manaflow-ai#15227) eae4994 Pin password badge actions to their source runtime (manaflow-ai#14921) fd96369 Check the owner of the Claude shim directory in the app, workspace commands and nushell (manaflow-ai#15185) 0ebf8d7 Fix main-thread freeze during SSH paste detection (manaflow-ai#15113) a98c560 test: pin font magnification in the Cloud outline attention test (manaflow-ai#15213)
1 participant
Summary
tests/test_issue_15066_zsh_watcher_sleep.py(added in #6032) failed on main run 36389234341 on a hosted macOS runner:fallback should launch sleep once for 20cs, got []. The fallback branch ran and printed its marker, but the fixture's fakesleep, first on the fixturePATH, was never called.zsh sources
/etc/zshenveven with-f. On a host where that file reordersPATH(for example throughpath_helper),sleepresolves to/bin/sleepbefore the fixture's copy. The owned runners and this Mac have no/etc/zshenv, which fits the test passing there. I could not read the hosted image's/etc/zshenv, so this cause is inferred. The test now restores the fixturePATHat the start of every zsh command. If the fallback check fails again, it also prints the resolvedsleeppath and the shell's output, which will confirm or rule out the cause.Testing
python3 tests/test_issue_15066_zsh_watcher_sleep.pypasses locally.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes the zsh watcher sleep test so it passes on hosted macOS runners where zsh sources a PATH-reordering
/etc/zshenv.sleepis always used.sleeppath and shell output when the fallback check fails, to confirm or rule out the cause.Written for commit 35cd134. Summary will update on new commits.