Repository navigation
fix(ci): restore app-host artifact rerun setup - #15029
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
teamleaderleo
changed the title
teamleaderleo
marked this pull request as ready for review
September 27, 2026 16:41
teamleaderleo
enabled auto-merge (squash)
September 27, 2026 16:41
Contributor
|
Merge receipt for |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 27, 2026
8efe28d Add terminal.confirmUnsafePaste to confirm unsafe pastes in a window sheet (manaflow-ai#14951) 368ec9f fix(ci): restore app-host artifact rerun setup (manaflow-ai#15029) e67ea0f perf: stop launching the cmux CLI for every queued Claude hook (manaflow-ai#14931) badf9f6 test: give the tmux split mapping test its own portal authority (manaflow-ai#15028) 41a0c37 current-work: preserve remote machine kinds (manaflow-ai#14914) c842f7d test(hermes): wait for the hook installer instead of racing a 1 s deadline (manaflow-ai#15027) 810ffba fix(ci): resolve binary modules in detached test reruns (manaflow-ai#15026) d363290 test: await fork probe fixture start signals (manaflow-ai#15025) 8c98e64 Add cmux import for settings from other terminals (manaflow-ai#15004) 30aa6c1 Keep SSH workspace titles when cmux-tui creates the remote workspace (manaflow-ai#14976) b33c467 Restore workspace group color and icon key handling from manaflow-ai#13877 (manaflow-ai#15000) # Conflicts: # .github/workflows/app-host-test-rerun.yml # .github/workflows/ci-macos.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App-host artifact reruns failed during compilation when every resolved binary framework variant became visible, then stopped before tests because diagnostic cleanup unconditionally required sudo. This repairs both setup failures without rebuilding the app or changing artifact identity, runner admission, or console-session checks.
Recover binary module search paths only for frameworks embedded in the adopted app or selected test bundle and missing usable archived module files. Preserve existing importable frameworks, select compatible macOS slices, and reject ambiguous matches. Collect this job’s existing xcodebuild and console captures, preserving rebuilt-run logs before the baseline, without deleting global debug logs or changing ownership.
Separate regression/fix commits cover unused binary variants and execute the workflow’s test/baseline/collection steps with sudo denied. All 49 helper tests and 12 applicable local static checks pass.
At
e70c4a78469011034a7d520bd1b21365d77ff26c, native run36333697551 rebuilt the test bundle against the existing product and completed both selected executions: 71 tests passed with the repaired fixture (10.506 seconds), and 71 baseline tests passed (10.570 seconds). Log collection and cleanup also passed. The baseline’s earlier timing failures did not recur in this focused run.The prior native compile passed after the module-selection correction but stopped before tests at the diagnostic sudo command fixed here.
Follows #15026. The original variant-cycle failure remains available.
Changelog
none