Repository navigation
fix(ci): resolve binary modules in detached test reruns - #15026
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Toolbox g1 🔔 checked the rerun-helper diff and its 48-test regression suite. All actionable CI checks are green; macOS admission is correctly skipped for this non-macOS change. CodeRabbit is still pending, so I’m leaving the branch intact until that review completes. |
|
Toolbox g1 🔔 reviewed the detached rerun fix and its targeted regression: it selects only matching macOS XCFramework slices, rejects path escapes, wires the adopted architecture through CI, and leaves runtime-only copies out of search paths. All actionable checks are green; proceeding with the normal squash merge while CodeRabbit remains non-required/pending. |
|
Merge receipt for |
8efe28d Add terminal.confirmUnsafePaste to confirm unsafe pastes in a window sheet (manaflow-ai#14951) 368ec9f fix(ci): restore app-host artifact rerun setup (manaflow-ai#15029) e67ea0f perf: stop launching the cmux CLI for every queued Claude hook (manaflow-ai#14931) badf9f6 test: give the tmux split mapping test its own portal authority (manaflow-ai#15028) 41a0c37 current-work: preserve remote machine kinds (manaflow-ai#14914) c842f7d test(hermes): wait for the hook installer instead of racing a 1 s deadline (manaflow-ai#15027) 810ffba fix(ci): resolve binary modules in detached test reruns (manaflow-ai#15026) d363290 test: await fork probe fixture start signals (manaflow-ai#15025) 8c98e64 Add cmux import for settings from other terminals (manaflow-ai#15004) 30aa6c1 Keep SSH workspace titles when cmux-tui creates the remote workspace (manaflow-ai#14976) b33c467 Restore workspace group color and icon key handling from manaflow-ai#13877 (manaflow-ai#15000) # Conflicts: # .github/workflows/app-host-test-rerun.yml # .github/workflows/ci-macos.yml
App-host artifact reruns failed to compile tests importing Sparkle and Iroh after Xcode removed their standalone build products. The archived runtime frameworks lack module headers. The detached test build now discovers compatible macOS slices in the binary XCFrameworks already resolved by SwiftPM and adds their directories to framework search paths, using the adopted product’s architecture.
The regression exercises the generated detached build configuration with two binary frameworks, runtime-only copies, spaces in paths, and incompatible iOS, Catalyst, and Intel-only slices. It fails before the repair and passes afterward. All 48 rerun-helper tests pass; all 12 applicable local static checks pass. Native rerun validation is pending. The original setup failure is run36330864494.
Changelog
none
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes detached app-host test reruns failing to compile when tests import binary frameworks like Sparkle and Iroh. Archived runtime copies lack module headers, so the build now resolves the matching macOS slice from the SwiftPM-resolved XCFrameworks and adds its directory to framework search paths.
--xcframework-rootand--archarguments to the detach command; only slices matching the adopted product's architecture are used.Written for commit 8817320. Summary will update on new commits.
Summary by CodeRabbit