Skip to content

docs(testing): describe how run-e2e.sh actually picks the runner - #14620

Merged
teamleaderleo merged 2 commits into
mainfrom
docs/e2e-runner-pick
Sep 25, 2026
Merged

teamleaderleo merged 2 commits into
mainfrom
docs/e2e-runner-pick

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

The cmux-testing reference said the wrapper sends a commit to the 12vcpu or 6vcpu Blacksmith pool by the parity of its SHA. That rule is gone: auto now goes through scripts/ci/e2e_runner_pool.py, the same rule pull request CI uses (an owned Mac with a free slot, then 12vcpu while it has headroom, then 6vcpu, then the shorter queue).

Agents read this file before dispatching E2E runs. It now says that naming a Blacksmith pool skips idle owned Macs, and that a pinned pool's queue can run past an hour. At 11:40 UTC today the Blacksmith macOS pools held about 237 queued jobs, with the oldest waiting 76 minutes.

Docs only.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Updates the cmux-testing docs to reflect how run-e2e.sh actually picks its runner. The old rule (runner chosen by the parity of the commit's SHA) is gone; auto now uses scripts/ci/e2e_runner_pool.py, the same logic pull request CI uses: an owned Mac with a free slot, then blacksmith-12vcpu-macos-26 while it has headroom, then blacksmith-6vcpu-macos-26, then the shorter queue. The docs also note that naming a Blacksmith pool skips idle owned Macs and can queue for an hour or more when many branches are running at once.

  • Leaving --runner off also lets the wrapper attach to an identical run already in flight at that commit on any of those pools; naming a pool only reuses runs on that pool.

Docs only.

Written for commit c901c24. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Documentation
    • Clarified how automatic runner selection prioritizes available Macs and Blacksmith pools, and how specifying a pool affects wait times and reuse of in-flight runs.
    • Confirmed that the macOS 15 runner remains available for macOS 15-specific checks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 31386779-e9ef-4d58-9ca8-8b914042c9af

📥 Commits

Reviewing files that changed from the base of the PR and between 0dba677 and c901c24.

📒 Files selected for processing (1)
  • skills/cmux-testing/references/local-vs-ci-validation.md
 ________________________________________________________________________
< I'm CodeRabbit. I review the code you never knew you needed reviewing. >
 ------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Sep 25, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@teamleaderleo
teamleaderleo merged commit fc112a8 into main Sep 25, 2026
51 of 52 checks passed
@teamleaderleo
teamleaderleo deleted the docs/e2e-runner-pick branch September 25, 2026 12:58
@github-actions

Copy link
Copy Markdown
Contributor

Merge receipt for c901c2452f: every check was green at merge (8 verified; 11 skipped by policy). Full suite runs on main after merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 25, 2026
c055747 ci: parse runner expressions in the fork guard, and gate LINUX_RUNNER on fork PRs (manaflow-ai#14192)
fc112a8 docs(testing): describe how run-e2e.sh actually picks the runner (manaflow-ai#14620)
0f6edfa ci(owned): keep seeds until the disk is actually short, not at a fixed 6 (manaflow-ai#14621)
1b78097 CI: one owned-pool rescue sweeper instead of a rescue run per CI run (manaflow-ai#14602)
c7e79f6 Hold Files tree reloads while its context menu is open (manaflow-ai#14451)
dbb24cb ci: read the owned-pool rescue's Actions API through the route App (manaflow-ai#14499)
36b8063 ci: store each app-host product file once in the product archive (manaflow-ai#14601)
0dba677 CI: run CmuxWorkspaces package tests (manaflow-ai#14592)
2244e98 Fix color detection in native tmux mirrors (manaflow-ai#14175)
3d2478e build: keep every built file in a project group so Xcode reuses its build description (manaflow-ai#14486)
a1a5ae9 ci(cmux-tui): cache cargo builds in the Rust jobs (manaflow-ai#14613)
560e640 ci(owned): keep 8 seeds per mini and pick seeds by cost, not a 2-commit cap (manaflow-ai#14607)
561d317 cmux-debug-cli: find a publish-hq build in the HQ tag app cache (manaflow-ai#14579)
c0aaac7 fix(events): survive receive-timeout reconfiguration churn during replay (manaflow-ai#13888)
3bd994a fix: keep split zoom when the zoomed pane outlives a tab close (manaflow-ai#12853)
ca984c7 Session snapshots can send binding actions to ghostty on a surface that is no longer live (manaflow-ai#12623)
a47d65b settings: expose local tmux session persistence (manaflow-ai#13210)
e3acb25 ci: give an owned Mac's full app rebuild 35 minutes to compile (manaflow-ai#14594)

# Conflicts:
#	.github/workflows/ci-artifact-transport.yml
#	.github/workflows/ci-cache-receipts.yml
#	.github/workflows/ci-guards.yml
#	.github/workflows/ci-macos.yml
#	.github/workflows/ci-owned-pool-rescue.yml
#	.github/workflows/ci-web.yml
#	.github/workflows/ci.yml
#	.github/workflows/cloud-machine-tests.yml
#	.github/workflows/cloud-vm-guest-install.yml
#	.github/workflows/cloud-vm-image-contract.yml
#	.github/workflows/cloud-vm-image-reachability.yml
#	.github/workflows/cloudflare-relay.yml
#	.github/workflows/cmux-skill-contract.yml
#	.github/workflows/cmux-tui-sdks.yml
#	.github/workflows/cmux-tui-spec.yml
#	.github/workflows/cmux-tui.yml
#	.github/workflows/indexnow-tests.yml
#	.github/workflows/iroh-v2.yml
#	.github/workflows/localization-catalog.yml
#	.github/workflows/r2-upload-tests.yml
#	.github/workflows/remote-daemon.yml
#	.github/workflows/repair-nightly-appcast-content-types.yml
#	.github/workflows/required-checks-drift.yml
#	.github/workflows/resolve-dispatch-ref.yml
#	.github/workflows/seed-derived-data.yml
#	.github/workflows/terminal-hang-diagnostics.yml
#	.github/workflows/test-e2e.yml
#	.github/workflows/test-ios.yml
#	.github/workflows/testbox-broker-guard.yml
#	.github/workflows/web-validation.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant