build: keep every built file in a project group so Xcode reuses its build description

[teamleaderleo]

Every incremental cmux build, no-ops included, recreates Xcode's build description. The fleet measures that step at 32-35 s per build on cmux11s, about half of a 65-75 s no-op, and it doesn't change with the size of the edit.

Cause. Two files in the app's Sources phase belong to no group: MacDevicesComposition.swift (since 9401c25) and SurfaceCatalogSnapshot+DeviceVisibility.swift (since 6d5c49b). Xcode files such references under a synthesized "Recovered References" group whose GUID is new on every project load. The PIF therefore differs on every build, the build-description cache can never hit, and Xcode re-plans every time. This is the same failure #12976 fixed on 09-19.

Evidence.

• xcodebuild -dumpPIF three times on an unchanged main tree gives three different hashes. The only differing leaves are that group's GUID and the signatures derived from it.
• With this change, three dumps are byte-identical (736481854324a01c).
• In run 36118886107 (the edit-loop benchmark on this branch's parent), 15 of 15 reload builds logged CreateBuildDescription with a new signature, while the xcodebuild invocations were identical.

Change.

• Both file references now sit in the groups their siblings use (Sources, Sources/Surfaces), with paths relative to those groups.
• New scripts/check-pbxproj-group-membership.py, run by check-pbxproj.sh, fails when a file a build phase lists belongs to no group. It flags exactly these two on current main and passes here.
• Drops the dead CloudRequestClock.swift build-file and file-reference objects that refactor: move the Cloud services and values layer into a CmuxCloud package #14343 left behind. No phase or group referenced them.

check-pbxproj.sh, lint-pbxproj-test-wiring.sh and the three Python tests that reference check-pbxproj.sh pass. The wall-clock effect on reload builds gets measured next in the edit-loop benchmark.

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Keeps every built file in a project group so Xcode stops re-planning every no-op build. Two files in the Sources phase belonged to no group, so Xcode filed them under a synthesized "Recovered References" group with a new GUID on every load; the PIF then differed on every build, the build-description cache never hit, and no-op builds spent an extra 32-35 s re-planning. With this change, three -dumpPIF runs on an unchanged tree are byte-identical.

• Moves MacDevicesComposition.swift into Sources and SurfaceCatalogSnapshot+DeviceVisibility.swift into Sources/Surfaces, with paths relative to those groups.
• Adds scripts/check-pbxproj-group-membership.py, run by check-pbxproj.sh, that fails when a build-phase file is not reachable from the main group. The guard parses the project with normalize-pbxproj.py's tokenizer rather than a line regex, which missed space-indented objects, two objects on one line, and ids longer than 24 characters.
• Registers the guard as non-product tooling and covers it in the normalizer tests.
• Drops the dead CloudRequestClock.swift build-file and file-reference objects left behind by refactor: move the Cloud services and values layer into a CmuxCloud package #14343.

^{Written for commit cf20bda. Summary will update on new commits.}

[coderabbitai]

Warning

Review limit reached

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6c6351b4-7cb6-41cc-b9b9-31e58619b7ec

📥 Commits

Reviewing files that changed from the base of the PR and between d2542e5 and cf20bda.

📒 Files selected for processing (7)

• cmux.xcodeproj/project.pbxproj
• scripts/check-pbxproj-group-membership.py
• scripts/check-pbxproj.sh
• scripts/ci/product_input_identity.py
• scripts/verify-local.py
• tests/test_normalize_pbxproj.py
• tests/test_reuse_app_host_products.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[github-actions]

Merge receipt for cf20bda571: every check was green at merge (12 verified; 14 skipped by policy). Full suite runs on main after merge.