Repository navigation
ci: start Linux-only jobs beside Fast static checks - #14181
Conversation
guards, the GhosttyKit release check, browser and web run only on Linux but wait for Fast static checks before starting, adding that job to every pull request's critical path. Pin that they need only `changes`, that every Mac-runner job still waits for the static stage, and that the admission gate and both verdict jobs still require it. Fails on this commit: guards still needs static-preflight. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#13177 made guards, the GhosttyKit release check, browser and web wait for Fast static checks so a lint failure would not spend runners on them. None of them reads an output from it; the wait only orders, and it puts the whole static job on every pull request's critical path to save a few Linux minutes on a red lint. Those four jobs now need only `changes`. Everything that starts a Mac (claude-wrapper, remote-daemon, cli, the admission gate and macos) still waits for and requires a green static stage, and linux-preflight and ci-status still fail the run when it is red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughFour Linux-only CI jobs now run after ChangesCI job scheduling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to Linux checks can start alongside static checks, while the final CI verdict still fails if static checks fail. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 1 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
…eflight-wait # Conflicts: # .github/workflows/ci.yml # tests/test_ci_change_areas.py
4aa2736 Fix cmux events access-denied stream error (manaflow-ai#10712) f4ff9af ci: never let a focused test run pass after executing zero tests (manaflow-ai#14053) fbaf239 Fix persistent LaunchServices registration from duplicate plist keys (manaflow-ai#12990) 7b1cb4a Fix Hermes gateway with symlinked venv Python (manaflow-ai#12996) b6b2720 ssh-tmux mirror: preserve deliberate pane titles (manaflow-ai#10714) 33edbc7 Fix Cloud VM panel text readability across all terminal themes (manaflow-ai#7538) 30dccd6 fix: prevent detached TUI preferred editor processes (manaflow-ai#10681) 22eec58 Reap disowned shell watchers on parent PID reuse (issue 10926) (manaflow-ai#11035) 0b9b318 ci: start Linux-only jobs beside Fast static checks (manaflow-ai#14181) 9e78d22 ci: one git archive for the trusted router; delete duplicate CI guard tests (manaflow-ai#14199) 20e79e6 feat: load local cmux config packs (manaflow-ai#13356) 224327b ci: download the admission DerivedData seed while packages resolve (manaflow-ai#14184) 886a6f0 ci: run changed suites inside compile admission (manaflow-ai#14182) # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/ci.yml # .github/workflows/test-e2e.yml # .github/workflows/test-macos-suite.yml
Every pull request waits for Fast static checks (about 0.4 min) before guards, the GhosttyKit release check, browser and web can start, so the whole static job sits on the critical path. On Linux-only PRs the median run is 2.4 min, so this wait is a real share of it. With this change those four jobs start as soon as
changesfinishes, alongside the static job.#13177 added the wait on purpose, as a "don't spend runners if lint fails" gate. None of the four reads a static-preflight output, so the wait only controls ordering. All four run only on Linux, where a few extra minutes on a red lint cost less than 0.4 min on every green run.
Mac work still waits for it.
claude-wrapper,remote-daemon,cli,macos-admission-gateandmacoskeepneeds: static-preflight, and the gate andmacosstill require it to succeed, so a lint failure still starts no Mac runner.linux-preflightandci-statusstill fail the run when the static job is red.Testing
test_only_mac_work_waits_for_static_preflight. It fails on that commit atguards, and passes with the fix in b403c1a. The test pins that the four Linux jobs need onlychanges, that every job with a Mac runner still needsstatic-preflight(derived fromruns-on), and that the admission gate and both verdict jobs keep it.python3 tests/test_ci_change_areas.pypasses. That includes the derived admission-gate membership test, which still picks up all four jobs.tests/test_ci_guard_workflow_structure.pyandtests/test_ci_linux_guard_routing.py(30 tests) pass, andactionlint .github/workflows/ci.ymlis clean.run:block locally. The steps that still fail don't readci.yml, and they're environmental: missing submodules,RUNNER_TEMP, two 20-minute app-host shell timeouts, andtest_ci_virtual_display_lock.sh, which fails the same way on origin/main.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Starts the four Linux-only CI jobs (
guards,ghosttykit-release-check,browser,web) as soon aschangesfinishes instead of queueing them behindstatic-preflight, removing the static job from every pull request's critical path. On Linux-only PRs the median run is 2.4 min, so the ~0.4 min wait was a real share. The wait only ordered jobs; none of the four reads a static-preflight output. Mac work is unaffected:claude-wrapper,remote-daemon,cli,macos-admission-gate, andmacosstill require a green static job before any Mac runner starts, andlinux-preflightandci-statusstill fail the run when the static job is red. Updatesdocs/contributor-verification.mdto describe this.Testing
test_only_mac_work_waits_for_static_preflight, which fails on the commits where the four jobs still wait.needs: [changes]dependency.Written for commit fbd0091. Summary will update on new commits.
Summary by CodeRabbit