Repository navigation
Split and shard the web CI critical path - #13437
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This was referenced Sep 21, 2026
teamleaderleo
enabled auto-merge (squash)
September 21, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Break the serial
web-typecheckgrab bag into independently scheduled checks.web-typecheckfocused on relay-catalog validation + the ~4s TypeScript gate;--shardmatrix workers;--with-depsfor host libraries;web-statusaggregate so required-check semantics stay fail-closed.On #13431 the old job was 286s: 4s typecheck, 166s web tests, 22s browser install, 77s instant-navigation. This change makes those costs concurrent and shards the largest serial block.
This does not change which diffs select the web area. Routing is handled separately in #13436.
Related: #13095, #13325.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Breaks the serial
web-typecheckCI job into parallel lanes so the TypeScript gate, the Bun test corpus, and the Playwright browser checks no longer run back to back. The combined job took 286s on a reference run; sharding the 166s test block across four workers and running the 77s browser lane concurrently brings the web critical path down to roughly the slowest lane.web-typecheckkeeps only the relay-catalog validation and the ~4s TypeScript gate.--shardmatrix workers; instant-navigation Playwright runs as a sibling job with a Playwright browser cache between runs.web-statusaggregates all three lanes so required-check semantics stay fail-closed.tests/test_ci_change_areas.pycovering the split lanes.This does not change which diffs select the web area; routing is handled separately in #13436.
Written for commit 9754446. Summary will update on new commits.