fix: remove remaining Cloud provider extension brace - #12558
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 14, 2026
97f8a15 Merge pull request manaflow-ai#12359 from manaflow-ai/fix/12355-cloud-hover-x bb519c9 Merge pull request manaflow-ai#12559 from manaflow-ai/issue-12505-revert-cloud-recovery 71fed10 Merge pull request manaflow-ai#12546 from manaflow-ai/issue-12532-agent-notification-flaky 03049fd Merge origin/main into issue-12505-revert-cloud-recovery 11e2ee0 Merge pull request manaflow-ai#12558 from manaflow-ai/issue-12547-nightly-provider-duplicates 2646f8d fix: preserve Cloud rename helper after full revert cd7fe4c fix: centralize Cloud hover ownership 4415352 test: cover Cloud hover transitions b6048d7 fix: keep CI diagnostics Python 3.9 compatible 419cf0a Merge pull request manaflow-ai#12549 from manaflow-ai/issue-12536-cloud-reconnect-overlay d22862e fix: remove stray Cloud provider brace 11e7507 fix: remove stale provider extension brace 4d38e75 Revert "Merge pull request manaflow-ai#12505 from manaflow-ai/issue-12469-cloud-terminal-recovery" 7b0499c fix: parse app-host diagnosis options safely d62e535 Merge remote-tracking branch 'origin/main' into issue-12532-agent-notification-flaky 1d51466 fix: always report pre-test failures 0eafa93 test(cloud): cover reconnect card dismissal 4a8908b fix: preserve nonzero app-host test exits 231698f test: keep clean app-host exits red 024a915 fix: classify app-host crash markers correctly 4ef3406 test: classify app-host crash output 688d55e fix: keep per-suite test result bundles isolated ebb9a9a test: distinguish app-host crashes from assertions 458bcdc fix(cloud): use one reconnect presentation owner 925c933 ci: report semantic app-host failure categories 3cbffd0 test: cover semantic app-host failure reporting # Conflicts: # .github/workflows/test-depot.yml
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12550; fixes #12547.
PR #12550 merged the provider deduplication commit, but its queued Nightly
mainbuild still compiled the pre-follow-up tree and failed on the extra closing brace left inCmuxTuiSurfaceProvider+TerminalIO.swift. This follow-up removes that stale brace. The branch contains only the two-line syntax correction relative to the already merged PR.Evidence:
CmuxTuiSurfaceProvider+TerminalIO.swift:13:1: error: Extraneous '}' at top level11e7507029: https://github.com/manaflow-ai/cmux/actions/runs/34791774001Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Removes a stray closing brace in
CmuxTuiSurfaceProvider+TerminalIO.swiftthat caused the Nightly build to fail with an extraneous}error. The branch contains only this two-line syntax fix relative to the already merged provider deduplication work.Written for commit 11e7507. Summary will update on new commits.