fix: unblock Nightly macOS build after Cloud provider extraction overlap - #12550
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 14, 2026
22ae1c5 Merge pull request manaflow-ai#12550 from manaflow-ai/issue-12547-nightly-provider-duplicates 528d92f fix: deduplicate Cloud provider implementations 8b6c6e0 Merge pull request manaflow-ai#12543 from manaflow-ai/issue-12540-cloud-leading-icon 3c0933d fix: place Cloud workspace identity before sidebar titles 944d910 test: require Cloud workspace badge before sidebar title 136dcd3 Merge pull request manaflow-ai#12534 from manaflow-ai/issue-12533-vercel-staging-guest-assets cc45e9d test(web): pin guest prompt asset bytes 5f1d135 fix(web): load guest prompt assets in Vercel builds 1f17bb3 Merge pull request manaflow-ai#4025 from manaflow-ai/issue-1756-pane-resize-keybindings 8831b43 Merge pull request manaflow-ai#12519 from manaflow-ai/issue-4701-webkit-activity-crash 2acbf93 Merge pull request manaflow-ai#12511 from manaflow-ai/issue-12480-cloud-pane-modal bc6d2e0 Merge origin/main into issue-4701-webkit-activity-crash 59facc1 Merge remote-tracking branch 'origin/main' into issue-1756-pane-resize-keybindings 2dd797c Merge remote-tracking branch 'origin/main' into issue-1756-pane-resize-keybindings 0f66315 test: cover revealed browser history restoration 3b4b441 test: import browser viewport package 0408681 fix: keep callback validation inside browser owner 4d742d4 fix: expose browser callback generation check dff60ee Merge remote-tracking branch 'origin/main' into issue-4701-webkit-activity-crash f53518a fix: fence stale browser lifecycle callbacks e053fb7 fix: complete cross-file browser lifecycle access 21d4bd9 fix: expose panel state to web content lifecycle owner d3c3cb1 fix: include browser stream state in discard snapshot 0e576a7 fix: keep browser delegate accessible to recovery lifecycle 57897e8 fix: expose portal lock for browser lifecycle extension 8968961 fix: defer WebKit WebContent replacement until recovery 8d41c77 test: defer WebKit termination replacement until recovery 4bc58c7 fix: fence superseded cloud pane failures 8c35c0a test: exercise live Dock tab identity in link routing fixture 1c001e1 fix: isolate cloud failure ownership on main actor 14de512 test: model cloud tab identity in failure fixture a5df8d0 test: assert cloud failure copy is sanitized 8d9f0a3 test: supply drag registry in Cloud sidebar scale fixture e3566cd fix: harden cloud pane failure state 74d0d40 test: align terminal link fixture with current container protocol 2a80d3f Merge remote-tracking branch 'origin/main' into issue-12480-cloud-pane-modal 8787859 fix: show cloud pane creation failures inline b75b987 fix: use public Bonsplit tab identity for Cloud layout projection 9713e46 test: preserve settings isolation when resize actions are absent 8de947b fix: restore terminal primitives lost in Cloud provider extraction 26cc800 fix: accept indexed resources in Cloud workspace reconciliation c7954be fix: keep resize settings typed and expose Dock palette actions 8154cfb fix: quote resize test extension path in Xcode project d077aec test: disambiguate app shortcut type in resize coverage 1b6d97a Merge remote-tracking branch 'origin/main' into issue-1756-pane-resize-keybindings f1cb666 style: trim extracted settings file boundaries 2b4b176 feat: finish configurable pane resize shortcuts across workspace and Dock 253bbbe Merge remote-tracking branch 'origin/issue-1756-pane-resize-keybindings' into issue-1756-pane-resize-keybindings 766c819 test: cover pane resize routing, repeat, and settings validation 9548f46 test: cover non-modal cloud pane creation failure 3eabdcc fix: address pane resize review feedback 7f87e23 Merge remote-tracking branch 'origin/main' into issue-1756-pane-resize-keybindings 4617dac feat: add pane resize shortcuts
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12547.
Nightly Release compilation was blocked after overlapping Cloud provider extraction merges left the same protocol methods in both the provider god file and extracted extensions. This patch keeps one authoritative implementation per method:
CmuxTuiSurfaceProvider+PendingCreationRecovery.swift;CmuxTuiSurfaceProvider+TerminalPrimitives.swift, with text sent over stdin;CmuxTuiSurfaceProvider+CloseTerminal.swift;attachCommanddeclaration is restored;remoteNamehelper;Validation:
python3 scripts/swift_file_length_budget.pybash scripts/lint-pbxproj-test-wiring.shpython3 scripts/check-package-resolved-policy.pypython3 scripts/localization_catalog.py checkbuild_only=trueuniversal Release run: https://github.com/manaflow-ai/cmux/actions/runs/34791367595Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes #12547. Unblocks the Nightly macOS build after overlapping Cloud provider extraction merges left duplicate protocol methods. The provider now keeps one authoritative implementation per method, and terminal input is sent over stdin instead of argv so it can't be truncated or exposed in process listings.
Bug Fixes
CmuxTuiSurfaceProvider+PendingCreationRecovery.swift; terminal primitives and close compatibility live in their extracted extensions.attachCommanddeclaration, the Cloud workspace renameremoteNamehelper, and the Cloud tree cell's current row initializer.Written for commit 528d92f. Summary will update on new commits.