cloud: surface whether after() has waitUntil for deferred create work - #11782
Merged
Merged
Conversation
Deferred create work (edge probe, plan reconcile) shows fetch spans of under 4 ms and no log lines in production, consistent with the function being frozen right after the response. runAfterResponse swallowed Next's E91 error. It now logs a warning before the response and stamps cmux.after_response.mode on the request span, so Axiom and the function logs show which path ran.
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 3, 2026
3cce67c Vault: recency-first All Sessions view, session search, and checkpoints with fork (manaflow-ai#10215) 94f51fb Fix aggregate child memory pressure before compressor exhaustion (manaflow-ai#10773) 13006ef cloud: surface whether after() has waitUntil for deferred create work (manaflow-ai#11782) 75eee0e Cloud VMs: bake the TigerVNC desktop (dock, wallpaper, cua-driver, noVNC) into the devbox recipe and open it at the machine's private address (manaflow-ai#11776) 36b5536 Fix terminal text bleed during live window resize (manaflow-ai#11530) 44b42c1 Cloud VMs: machines usage decoder and refresh fixes, edge smoke diagnostics (manaflow-ai#11759) f11be3a ci(tui): scope Valgrind test compilation (manaflow-ai#11750) 9184f4c coderouter: many Claude upstream accounts per team, routed with affinity and cooldown failover (manaflow-ai#11775) d3b9cdd cloud: attach waits for the baked supervisor; edge probe span joins the create trace (manaflow-ai#11777) c69e317 test: make the cmuxTests target compile again (main-actor call, CLI-only type) (manaflow-ai#11770) 8185825 fix(history): stop idle History menu graph rebuild loop (manaflow-ai#10661) 723958e Test bounded stale-port retirement after listener exit (manaflow-ai#11356) 367682e Fix native terminal Copy honoring Ghostty clipboard flavor (manaflow-ai#11515) d59055d docs(tui): refresh SDK inventory counts (manaflow-ai#11766) 89e4701 cmux-tui: use JoinSet shutdown for simple drains (manaflow-ai#11745) # Conflicts: # .github/workflows/cmux-tui.yml
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deferred create work from #11756 and #11771 (plan reconcile, coderouter edge probe) shows in production traces as fetch spans of 0.5 to 4 ms with no log lines, which is what a function frozen right after the response looks like. Next's
after()throws E91 when the platform provides nowaitUntil;runAfterResponsecaught that silently and ran the work detached.This PR keeps the behaviour and makes it visible: a
console.warnbefore the response whenafter()is unavailable, andcmux.after_response.mode(afterordetached) on the request span. The next production create tells us which path we are on; if it isdetached, the follow-up is wiringwaitUntil(or moving the probe to the reconcile cron), not more guessing.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Makes deferred create work's execution mode visible so production traces show whether
after()hadwaitUntilsupport.runAfterResponsepreviously swallowed Next's E91 error and ran the work detached without a trace. It now logs a warning before the response and setscmux.after_response.mode(afterordetached) on the request span, so Axiom and function logs show which path ran.Written for commit 37d4204. Summary will update on new commits.