Repository navigation
test: make the cmuxTests target compile again (main-actor call, CLI-only type) - #11770
Merged
Merged
Conversation
PresenceHeartbeatClient is @mainactor, so calling its static resolvedServiceURL from a nonisolated synchronous test fails to compile under Swift 6 isolation checking. Since #11524 the whole cmuxTests target failed to build in test-e2e.yml, so no unit test in the target could run (seen on https://github.com/manaflow-ai/cmux/actions/runs/33707324236).
|
Warning Review limit reachedNext included review available in 23 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
…le in cmuxTests ClaudeHookSessionStore lives in CLI/cmux.swift (cmux-cli target) and is not visible to the app test bundle, so the cmuxTests target failed to compile (cannot find 'ClaudeHookSessionStore' in scope) since #11529. Hook store behavior is covered by the CLI-binary harness tests (ClaudeHookLiveDeliveryTargetTests and friends); a direct persistence test needs to go through that harness.
lawrencecchen
changed the title
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 3, 2026
3cce67c Vault: recency-first All Sessions view, session search, and checkpoints with fork (manaflow-ai#10215) 94f51fb Fix aggregate child memory pressure before compressor exhaustion (manaflow-ai#10773) 13006ef cloud: surface whether after() has waitUntil for deferred create work (manaflow-ai#11782) 75eee0e Cloud VMs: bake the TigerVNC desktop (dock, wallpaper, cua-driver, noVNC) into the devbox recipe and open it at the machine's private address (manaflow-ai#11776) 36b5536 Fix terminal text bleed during live window resize (manaflow-ai#11530) 44b42c1 Cloud VMs: machines usage decoder and refresh fixes, edge smoke diagnostics (manaflow-ai#11759) f11be3a ci(tui): scope Valgrind test compilation (manaflow-ai#11750) 9184f4c coderouter: many Claude upstream accounts per team, routed with affinity and cooldown failover (manaflow-ai#11775) d3b9cdd cloud: attach waits for the baked supervisor; edge probe span joins the create trace (manaflow-ai#11777) c69e317 test: make the cmuxTests target compile again (main-actor call, CLI-only type) (manaflow-ai#11770) 8185825 fix(history): stop idle History menu graph rebuild loop (manaflow-ai#10661) 723958e Test bounded stale-port retirement after listener exit (manaflow-ai#11356) 367682e Fix native terminal Copy honoring Ghostty clipboard flavor (manaflow-ai#11515) d59055d docs(tui): refresh SDK inventory counts (manaflow-ai#11766) 89e4701 cmux-tui: use JoinSet shutdown for simple drains (manaflow-ai#11745) # Conflicts: # .github/workflows/cmux-tui.yml
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two PRs merged today left the
cmuxTeststarget uncompilable, so everycmuxTests/...dispatch oftest-e2e.ymlends with "Could not determine executed test count" and no unit test in the target runs (https://github.com/manaflow-ai/cmux/actions/runs/33707324236, https://github.com/manaflow-ai/cmux/actions/runs/33708419146).productionPresenceIgnoresStagingEnvironmentcalls the main-actor staticPresenceHeartbeatClient.resolvedServiceURLfrom a nonisolated synchronous test. Marked@MainActor, the pattern the other main-actor tests use.ClaudeHookSessionStorePersistenceTestsinstantiatesClaudeHookSessionStore, which is defined inCLI/cmux.swift(thecmux-clitarget) and is not visible to the app test bundle. It never compiled anywhere. Removed from the target; hook store behavior stays covered by the CLI-binary harness tests (ClaudeHookLiveDeliveryTargetTestsand friends). A direct persistence test for the store needs to go through that harness.Verification:
test-e2e.ymlon this branch withcmuxTests/VMClientTelemetryTests, which compiles the whole target and runs the tests added in #11755.