docs(tui): refresh SDK inventory counts - #11766
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe documentation updates protocol-12 coverage counts from 101 commands and 46 events to 104 commands and 47 events or event shapes across the TUI ergonomics and Go SDK documentation. ChangesProtocol count documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Documentation now reports 104 protocol-12 commands and 47 event shapes consistently in the SDK ergonomics and Go raw SDK pages. The counts are supported by generated coverage evidence, with no runtime or API changes. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Description checkExplanation The description provides the change summary, rationale, validation commands, and scope. It does not include the template's Review Trigger or Checklist sections, but the missing Demo Video is not applicable to this docs-only change. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) Full details: Cmux Swift Actor IsolationExplanation PASS: The pull-request commit changes only two Markdown documentation files. The exact parent-to-HEAD diff contains no Swift paths or production Swift declarations. Therefore, it does not introduce or worsen any Swift 6 actor-isolation issue covered by the rule. Full details: Cmux Swift Blocking RuntimeExplanation PASS: The pull-request diff changes only two Markdown files: Full details: Cmux Browser Automation Off-MainExplanation PASS: The exact PR diff changes only Full details: Cmux Expensive Synchronous LoadExplanation PASS: The pull-request commit changes only two Markdown files: Full details: Cmux Cache Substitution CorrectnessExplanation PASS: The pull request changes only two Markdown documentation files. The exact parent-to-HEAD diff contains no Swift, TypeScript, or JavaScript changes and no persistence, history, undo, or snapshot code changes. The cache-substitution correctness check is therefore not applicable. Full details: Cmux No Hacky SleepsExplanation PASS: The parent-to-HEAD diff changes only two Markdown documentation files. The changes update command and event counts from 101/46 to 104/47. No TypeScript, JavaScript, shell, or build/runtime file changed, and no fixed sleep or timer was introduced. Full details: Cmux Algorithmic ComplexityExplanation PASS: The parent-to-HEAD diff changes only two Markdown files: Full details: Cmux Swift ConcurrencyExplanation PASS. The HEAD diff changes only two Markdown documentation files: Full details: Cmux Swift `@Concurrent`Explanation PASS: The pull request changes only two Markdown files: Full details: Cmux Swift Package BoundariesExplanation PASS: The pull request changes only two Markdown documentation files: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
35ec423 to
150cb54
Compare
150cb54 to
6a544ff
Compare
3cce67c Vault: recency-first All Sessions view, session search, and checkpoints with fork (manaflow-ai#10215) 94f51fb Fix aggregate child memory pressure before compressor exhaustion (manaflow-ai#10773) 13006ef cloud: surface whether after() has waitUntil for deferred create work (manaflow-ai#11782) 75eee0e Cloud VMs: bake the TigerVNC desktop (dock, wallpaper, cua-driver, noVNC) into the devbox recipe and open it at the machine's private address (manaflow-ai#11776) 36b5536 Fix terminal text bleed during live window resize (manaflow-ai#11530) 44b42c1 Cloud VMs: machines usage decoder and refresh fixes, edge smoke diagnostics (manaflow-ai#11759) f11be3a ci(tui): scope Valgrind test compilation (manaflow-ai#11750) 9184f4c coderouter: many Claude upstream accounts per team, routed with affinity and cooldown failover (manaflow-ai#11775) d3b9cdd cloud: attach waits for the baked supervisor; edge probe span joins the create trace (manaflow-ai#11777) c69e317 test: make the cmuxTests target compile again (main-actor call, CLI-only type) (manaflow-ai#11770) 8185825 fix(history): stop idle History menu graph rebuild loop (manaflow-ai#10661) 723958e Test bounded stale-port retirement after listener exit (manaflow-ai#11356) 367682e Fix native terminal Copy honoring Ghostty clipboard flavor (manaflow-ai#11515) d59055d docs(tui): refresh SDK inventory counts (manaflow-ai#11766) 89e4701 cmux-tui: use JoinSet shutdown for simple drains (manaflow-ai#11745) # Conflicts: # .github/workflows/cmux-tui.yml
The protocol-12 SDK schema now contains 104 commands and 47 event shapes. Two documentation pages still reported the prior 101-command and 46-event inventory.
Update the SDK ergonomics report and Go raw SDK README to match the canonical generated schema. Evidence from cmux-tui/spec/sdk-schema.json: 104 commands, 47 events, including 46 emitted and one serialized-only event.
Validation:
Docs-only change. No runtime or generated artifacts changed.
Summary by cubic
Updates the SDK inventory counts in the ergonomics report and Go raw README from 101 commands and 46 events to 104 and 47, matching the canonical protocol-12 schema, and adds a conformance test that fails if the docs drift from the generated schema.
test_runner.pyreadssdk-schema.jsonand asserts the documented counts and matrix math stay in sync.Written for commit 6a544ff. Summary will update on new commits.
Summary by CodeRabbit