Repository navigation
fix(relay): make process-tree cleanup owner-stable - #11729
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
lawrencecchen
force-pushed
the
feat-supervisor-owner
branch
from
September 2, 2026 22:36
eaea46b to
c99f089
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 2, 2026
651e4f6 Merge pull request manaflow-ai#11729 from manaflow-ai/feat-supervisor-owner 4164ae1 Merge pull request manaflow-ai#11722 from manaflow-ai/feat-plugin-manager-hardening-main d49bda2 fix: combine journal sequence and cursor continuity checks (manaflow-ai#11468) ee3b0b4 fix(relay): drain pending process escalation before return 21ace78 fix(tui): distinguish local plugin Git paths b39ae5d fix(relay): bound keeper setup cleanup 1562cad test(tui): preserve local plugin Git paths b01cf06 fix(relay): disarm Windows jobs on normal completion c098bbf test(relay): preserve successful Windows process jobs 7de2d03 fix(tui): reject option-like SSH usernames ab23651 test(tui): reject option-like SSH usernames c99f089 fix(relay): keep process-group owner through grace period cc7e1e1 fix(relay): scrub process-group keeper environment ba2640e fix(relay): own process groups through bounded cleanup 5836c5f test(relay): cover owned process cancellation and timeout 8f41cf6 fix(tui): reject SSH option-like plugin hosts ad825ef test(tui): reject SSH option-like plugin hosts 7c4c752 fix(tui): classify common plugin credential variables a9ec9ea fix(tui): preserve plugin toolchain environment 8fc0e86 test(tui): preserve plugin toolchain environment 012569f fix(tui): close plugin source and environment escape hatches 3fe0d92 test(tui): reject plugin source options and env leaks edeed73 test(tui): close plugin source and environment escape hatches 63c0c25 fix(tui): reject Git credentials in all non-SSH URLs e480982 test(tui): reject credential-like Git userinfo 35bb023 fix(tui): allow IPv6 plugin Git sources df9e467 test(tui): preserve IPv6 plugin Git sources 0931ca2 fix(tui): bound and isolate plugin builds e199af9 test(tui): cover plugin transport and build boundaries 2c66ab9 iOS: use the official cmux brand lockup (manaflow-ai#11725) 368c47a docs(tui): align protocol contracts with runtime (manaflow-ai#11418) 3507ef0 iOS: launch with a cached session mounts the shell, not the sign-in loading screen (manaflow-ai#11564) cf475ff Merge pull request manaflow-ai#11727 from manaflow-ai/fix-tui-app-closure-type-main 6603bf7 fix(cmux-tui): annotate pane fixture closure input 1384921 Merge pull request manaflow-ai#11720 from manaflow-ai/fix-cli-upsert-arg-order a8dbaf4 fix(cli): order hookEventName before runtimeStatus in agent-hook upsert call
This was referenced Sep 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
rustfmt --edition 2024 --check cmux-tui/crates/chatmux-relay/src/actions.rs cmux-tui/crates/chatmux-relay/src/session.rsgit diff --checkSummary by cubic
Fixes process-tree cleanup in the relay so timeout and cancellation can no longer orphan descendants or signal a reused PID after the leader exits.
Behavior
ProcessTreeOwneron Unix so the process group remains valid until cleanup completes.process cancelledas a failed outcome.waiterrors are retried before escalation.Written for commit ee3b0b4. Summary will update on new commits.