Repository navigation
iOS: use the official cmux brand lockup - #11725
Conversation
|
To use Codex here, create a Codex account and connect to github. |
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe iOS branding updates replace the universal vector logo with scale-specific PNG assets, update launch-screen documentation, and adjust sign-in header typography and letter spacing. ChangesiOS branding
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized iOS branding update changes packaged assets and sign-in presentation without introducing a concrete correctness, security, availability, or deployment risk; no actionable merge-blocking risk remains beyond normal checks. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.) Full details: Cmux Swift Actor IsolationExplanation PASS: The branding PR changes only two typography modifiers in Full details: Cmux Swift Blocking RuntimeExplanation PASS: The PR changes only SwiftUI typography in Full details: Cmux Browser Automation Off-MainExplanation PASS: The PR diff from merge base Full details: Cmux Expensive Synchronous LoadExplanation PASS: The only production Swift diff changes Full details: Cmux Cache Substitution CorrectnessExplanation PASS — The net PR diff contains only sign-in typography, launch-screen comment, and logo asset changes. The only production Swift change updates Full details: Cmux No Hacky SleepsExplanation PASS. The PR changes SwiftUI code, Xcode project metadata, plist metadata, and image assets only. The rule covers non-Swift TypeScript, JavaScript, shell, and build/runtime scripts. The diff contains no covered production sleep, timer, polling, delayed-dispatch, or wall-clock synchronization changes. Full details: Cmux Algorithmic ComplexityExplanation PASS: The pull request adds no scalable collection iteration or collection rescanning. The only production Swift change is Full details: Cmux Swift ConcurrencyExplanation PASS — The PR changes only SwiftUI typography in Full details: Cmux Swift `@Concurrent`Explanation PASS: The only Swift change is in Full details: Cmux Swift Package BoundariesExplanation PASS. The only production Swift diff changes Full details: Description checkExplanation The description includes a clear summary, testing details, a demo note, and a checklist. It omits the repository review-trigger block and does not use the exact Demo Video section, but it provides sufficient information for review. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
651e4f6 Merge pull request manaflow-ai#11729 from manaflow-ai/feat-supervisor-owner 4164ae1 Merge pull request manaflow-ai#11722 from manaflow-ai/feat-plugin-manager-hardening-main d49bda2 fix: combine journal sequence and cursor continuity checks (manaflow-ai#11468) ee3b0b4 fix(relay): drain pending process escalation before return 21ace78 fix(tui): distinguish local plugin Git paths b39ae5d fix(relay): bound keeper setup cleanup 1562cad test(tui): preserve local plugin Git paths b01cf06 fix(relay): disarm Windows jobs on normal completion c098bbf test(relay): preserve successful Windows process jobs 7de2d03 fix(tui): reject option-like SSH usernames ab23651 test(tui): reject option-like SSH usernames c99f089 fix(relay): keep process-group owner through grace period cc7e1e1 fix(relay): scrub process-group keeper environment ba2640e fix(relay): own process groups through bounded cleanup 5836c5f test(relay): cover owned process cancellation and timeout 8f41cf6 fix(tui): reject SSH option-like plugin hosts ad825ef test(tui): reject SSH option-like plugin hosts 7c4c752 fix(tui): classify common plugin credential variables a9ec9ea fix(tui): preserve plugin toolchain environment 8fc0e86 test(tui): preserve plugin toolchain environment 012569f fix(tui): close plugin source and environment escape hatches 3fe0d92 test(tui): reject plugin source options and env leaks edeed73 test(tui): close plugin source and environment escape hatches 63c0c25 fix(tui): reject Git credentials in all non-SSH URLs e480982 test(tui): reject credential-like Git userinfo 35bb023 fix(tui): allow IPv6 plugin Git sources df9e467 test(tui): preserve IPv6 plugin Git sources 0931ca2 fix(tui): bound and isolate plugin builds e199af9 test(tui): cover plugin transport and build boundaries 2c66ab9 iOS: use the official cmux brand lockup (manaflow-ai#11725) 368c47a docs(tui): align protocol contracts with runtime (manaflow-ai#11418) 3507ef0 iOS: launch with a cached session mounts the shell, not the sign-in loading screen (manaflow-ai#11564) cf475ff Merge pull request manaflow-ai#11727 from manaflow-ai/fix-tui-app-closure-type-main 6603bf7 fix(cmux-tui): annotate pane fixture closure input 1384921 Merge pull request manaflow-ai#11720 from manaflow-ai/fix-cli-upsert-arg-order a8dbaf4 fix(cli): order hookEventName before runtimeStatus in agent-hook upsert call
This branch was successfully deployed
1 participant
Summary
-0.015emtracking while preserving Dynamic Type.Apple typography guidance: https://developer.apple.com/design/human-interface-guidelines/typography
Testing
git diff --check origin/main...HEADpasses.Demo
Checklist