Repository navigation
fix(relay): own the grep pattern before spawning the runner task - #11653
Merged
Merged
Conversation
The grep arm moved its process run into tokio::spawn in #11568, but the task still captured `pattern`, a &str borrowed from the request frame, so the 'static future held a borrow of `frame` and `empty_args`. chatmux-relay has not compiled on main since that merge (E0597 and E0521 at the spawn). Clone the pattern into an owned String before the spawn and move it into the argv. No behavior change. Claude-Session: https://claude.ai/code/session_01AvkeWizggvvUAngHyB7JUQ
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 2, 2026
5f1df81 Vpc dogfood fixes (manaflow-ai#11674) c7bbfae cloud: one devbox snapshot per Freestyle size; the plan's memory picks the size (manaflow-ai#11664) d18aa5f Merge pull request manaflow-ai#11670 from manaflow-ai/issue-remote-decode-errors cd7d971 Admin Pro roster loads on page render and streams the scans (manaflow-ai#11668) da8befc fix(remote): terminate reader on malformed JSON 8a93998 test(remote): cover malformed JSON cancellation ce4cd50 fix(relay): stop when process file setup fails (manaflow-ai#11491) e3b14a1 fix(cloud): Cmd+T on a cloud pane selects the new remote terminal (manaflow-ai#11612) d90d8b8 Send Durable Object errors to Sentry (manaflow-ai#11657) 1a86aca Admin Pro roster: bounded team lookups, truncation flag, scan sequence guard (manaflow-ai#11662) f277fe6 Merge pull request manaflow-ai#11643 from manaflow-ai/fix-11492-clone-killer 65c0c60 fix(test): make scoped attach killer mutable 8cdf1ce Cloud sidebar port links: direct private IPs, white link styling, reconnect-logic merge fix (manaflow-ai#11647) 6d1ca7e fix(tui): narrow workspace registry APIs (manaflow-ai#11498) 9f7ba2d Admin page: list every Pro user, team, and pending grant (manaflow-ai#11645) 23a5485 fix(relay): pin PTY cwd to validated descriptor (manaflow-ai#11417) 3214964 fix(relay): own the grep pattern before spawning the runner task (manaflow-ai#11653) 400d306 Fix devcontainer SSH TTY flag placement (manaflow-ai#9772) 613870c web: answer Stack Auth throttles on iroh routes with 429, add a Stack throttle circuit (manaflow-ai#11633) f6be8ff web: resolve unoffered Cloud VM sizes to the plan machine instead of 400 (manaflow-ai#11644) 6d67bc5 Kill unvisited subtrees when the SSH auth cleanup deadline expires (manaflow-ai#11584) 790a7d8 Admin Pro access page: grant users, teams, and emails, manual downgrade (manaflow-ai#11605) 9bf04a3 fix(web): render the coderouter dashboard at request time (manaflow-ai#11632) bcc362c test(cmux-tui): cover scoped attach PTY lifecycle (manaflow-ai#11492) 51a9495 Fix main CI after the Blaxel removal and non-root daemon landing (manaflow-ai#11586) accfbdf Harden cmux-tui executable resolution before spawn (manaflow-ai#11427) 05c631d web: skip irrelevant Vercel builds and defer old changelog pages (manaflow-ai#11413) 40fd841 fix: render cloud VM terminals through native Ghostty manual I/O (manaflow-ai#11523) 1dd28a9 cloud: Freestyle devbox snapshot on the public platform (ubuntu user, base toolchain, Blaxel desktop), promote script, manifest as source of truth (manaflow-ai#11601) 4940db8 Pricing: Pro $50, Team $60, plan machine 5 vCPU / 20 GB / 200 GB, 50 VMs per seat (manaflow-ai#11610)
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same two-line fix as #11634, recreated on current main because GitHub stopped updating that PR's head and mergeability. chatmux-relay has not compiled on main since #11568 (E0597/E0521 at the grep spawn). Focused hosted run on the original head, all green: https://github.com/manaflow-ai/cmux/actions/runs/33619939294
https://claude.ai/code/session_01AvkeWizggvvUAngHyB7JUQ
Summary by cubic
Fixes a compile error in
chatmux-relaywhere the grep action borrowed the pattern from the request frame, causing a lifetime error when the run was moved intotokio::spawn. The pattern is now cloned into an ownedStringbefore the spawn. No behavior change.Written for commit eeee401. Summary will update on new commits.