Skip to content

fix(relay): own the grep pattern before spawning the runner task - #11634

Closed
lawrencecchen wants to merge 2 commits into
mainfrom
fix-relay-grep-pattern-static
Closed

lawrencecchen wants to merge 2 commits into
mainfrom
fix-relay-grep-pattern-static

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

chatmux-relay has not compiled on main since #11568 merged: the grep arm's spawned task captured pattern, a &str borrowed from the request frame, so the 'static future held a borrow of frame and empty_args (E0597 at the unwrap_or(&empty_args) binding, E0521 at the tokio::spawn). Every cmux-tui.yml job failed at build on main, for example https://github.com/manaflow-ai/cmux/actions/runs/33616280724, and the open follow-up #11629 fails the same way (https://github.com/manaflow-ai/cmux/actions/runs/33618595740).

Fix: own the pattern as a String before the spawn and move it into the argv. Two lines, no behavior change.

Hosted focused run on this head, all green (Linux, macOS, MSRV 1.91, aarch64 release build): https://github.com/manaflow-ai/cmux/actions/runs/33619939294

#11629 touches the same block and will need origin/main merged in after this lands.

https://claude.ai/code/session_01AvkeWizggvvUAngHyB7JUQ


Summary by cubic

Fixes chatmux-relay not compiling on main by owning the grep pattern as a String before the spawned task runs.

  • The task no longer borrows from the request frame, resolving the E0597/E0521 errors.
  • No behavior change; the grep argv now moves the owned pattern instead of cloning it.

Written for commit ee1f7ba. Summary will update on new commits.

Review in cubic

The grep arm moved its process run into tokio::spawn in #11568, but the
task still captured `pattern`, a &str borrowed from the request frame, so
the 'static future held a borrow of `frame` and `empty_args`. chatmux-relay
has not compiled on main since that merge (E0597 and E0521 at the spawn).
Clone the pattern into an owned String before the spawn and move it into
the argv. No behavior change.

Claude-Session: https://claude.ai/code/session_01AvkeWizggvvUAngHyB7JUQ
@cursor

cursor Bot commented Sep 2, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cmux166 Building Building Preview Sep 2, 2026 10:38am UTC
cmux41 Building Building Preview Sep 2, 2026 10:38am UTC

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: d08f0d0e-636a-49c7-b20f-91e0c9753b45

📥 Commits

Reviewing files that changed from the base of the PR and between cbda3b0 and ee1f7ba.

📒 Files selected for processing (1)
  • cmux-tui/crates/chatmux-relay/src/actions.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Requesting approval: main has not compiled in chatmux-relay since #11568 (every cmux-tui.yml job fails at build). This is the two-line fix with a green focused run on the exact head (https://github.com/manaflow-ai/cmux/actions/runs/33619939294) and a clean local review gate. The main ruleset now requires approval from someone other than the last pusher, so lawrencecchen cannot land it alone.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Superseded by #11629, which carries this pattern-ownership fix together with bounded cancelled-child reaping on the current main base. Keeping this PR open would duplicate the same change.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Superseded by #11653 (same fix, merged as 3214964); GitHub stopped updating this PR's head after the branch moved.

@vercel
vercel Bot temporarily deployed to Preview – cmux41 September 3, 2026 08:52 Inactive
@vercel
vercel Bot temporarily deployed to Preview – cmux166 September 3, 2026 08:53 Inactive

This branch was previously deployed

2 inactive deployments
Preview – cmux166 — ee1f7bae Deployed Sep 3, 2026 by vercel[bot]
Preview – cmux41 — ee1f7bae Deployed Sep 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant