Repository navigation
fix(relay): own the grep pattern before spawning the runner task - #11634
lawrencecchen wants to merge 2 commits into
Conversation
The grep arm moved its process run into tokio::spawn in #11568, but the task still captured `pattern`, a &str borrowed from the request frame, so the 'static future held a borrow of `frame` and `empty_args`. chatmux-relay has not compiled on main since that merge (E0597 and E0521 at the spawn). Clone the pattern into an owned String before the spawn and move it into the argv. No behavior change. Claude-Session: https://claude.ai/code/session_01AvkeWizggvvUAngHyB7JUQ
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Warning Review limit reachedNext included review available in 9 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Requesting approval: main has not compiled in chatmux-relay since #11568 (every cmux-tui.yml job fails at build). This is the two-line fix with a green focused run on the exact head (https://github.com/manaflow-ai/cmux/actions/runs/33619939294) and a clean local review gate. The main ruleset now requires approval from someone other than the last pusher, so lawrencecchen cannot land it alone. |
|
Superseded by #11629, which carries this pattern-ownership fix together with bounded cancelled-child reaping on the current main base. Keeping this PR open would duplicate the same change. |
chatmux-relay has not compiled on main since #11568 merged: the grep arm's spawned task captured
pattern, a&strborrowed from the request frame, so the'staticfuture held a borrow offrameandempty_args(E0597 at theunwrap_or(&empty_args)binding, E0521 at thetokio::spawn). Every cmux-tui.yml job failed at build on main, for example https://github.com/manaflow-ai/cmux/actions/runs/33616280724, and the open follow-up #11629 fails the same way (https://github.com/manaflow-ai/cmux/actions/runs/33618595740).Fix: own the pattern as a
Stringbefore the spawn and move it into the argv. Two lines, no behavior change.Hosted focused run on this head, all green (Linux, macOS, MSRV 1.91, aarch64 release build): https://github.com/manaflow-ai/cmux/actions/runs/33619939294
#11629 touches the same block and will need
origin/mainmerged in after this lands.https://claude.ai/code/session_01AvkeWizggvvUAngHyB7JUQ
Summary by cubic
Fixes
chatmux-relaynot compiling on main by owning the grep pattern as aStringbefore the spawned task runs.Written for commit ee1f7ba. Summary will update on new commits.