Skip to content

fix(relay): cancel tunnel opens on parent shutdown - #11554

Closed
lawrencecchen wants to merge 2 commits into
mainfrom
issue-11401-open-cancel
Closed

lawrencecchen wants to merge 2 commits into
mainfrom
issue-11401-open-cancel

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • race tunnel frame handling, including open, against parent and connection cancellation
  • close the tunnel promptly when provider open work does not return
  • add a bounded regression test with a deliberately suspended PTY provider

Verification

  • rustfmt --edition 2024 --check
  • git diff --check
  • no local Cargo tests or builds run per task constraints

This is a separate follow-up for #11401 and does not modify #11401, #11505, or #11526.


Summary by cubic

Completes the #11401 follow-up: tunnel opens now cancel when the parent shuts down, so relay connections close promptly instead of waiting out the open timeout.

  • Races every tunnel frame, including OPEN, against parent cancellation and connection close.
  • Adds a bounded regression test with a suspended PTY provider.

Written for commit 2b360c8. Summary will update on new commits.

Review in cubic

@cursor

cursor Bot commented Sep 2, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@vercel

vercel Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cmux166 Ready Ready Preview Sep 2, 2026 9:18pm UTC
cmux41 Ready Ready Preview Sep 2, 2026 9:18pm UTC

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 0459f350-96b5-4377-8894-7ba841063d56

📥 Commits

Reviewing files that changed from the base of the PR and between 0247f51 and 2b360c8.

📒 Files selected for processing (1)
  • cmux-tui/crates/chatmux-relay/src/tunnel_terminal.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamleaderleo

Copy link
Copy Markdown
Collaborator

Superseded by #11155, which carries this cancellation coverage together with the follow-on resource cleanup.

This branch was successfully deployed

2 active deployments
Preview – cmux166 — 2b360c88 Deployed Sep 2, 2026 by vercel[bot]
Preview – cmux41 — 2b360c88 Deployed Sep 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants