Repository navigation
fix(relay): close cancelled PTY resources - #11155
lawrencecchen wants to merge 53 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7671362 to
728f273
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Fleet instruction update for head |
Summary
spawn_blockingPTY handoffBase:
fix/tui-tunnel-security-followup(stacked follow-up to PR #11119).Verification
rustfmt +1.95 --edition 2024 --checkon changed relay filesverify-cmux-tui-hosted.sh --filter chatmux_relaypending for current headNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Cancelled tunnel opens previously could leave PTY/pipe children, control sockets, or daemon processes behind; cleanup is now bounded, rerun-safe, and identity-fenced, killing process groups with escalating waits and removing a socket only when its device/inode matches the daemon this relay spawned. Authority revocation fails closed, so validated
openedand output frames are re-checked at enqueue and cannot cross the revocation boundary.spawn_blockinghandoffs retain a cancellation owner; child process groups are reaped with bounded waits, escalating to detached fallback reapers..spawn-lock, nowO_NOFOLLOW, owner-only, and migrated to0600on open; rerunning cleanup skips sockets owned by a replacement daemon and only unlinks inode-matched, non-symlink sockets.trust_revokedfor cancelled opens.Written for commit fea1073. Summary will update on new commits.