Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings to package.json export #517

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

octave08
Copy link
Contributor

@octave08 octave08 commented May 18, 2023

📦 Pull Request

[Provide a general summary of the pull request here.]
Cannot find types of magic-sdk in vite-react app

image

✅ Fixed Issues

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]
Create a new vite-react app with the below commend

npx vite@latest

Install magic-sdk and check if types of magic-sdk is loaded

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@octave08 octave08 requested a review from Ethella May 18, 2023 09:18
@octave08 octave08 changed the title Update package.json to resolve missing types in vite-react app (DO NOT MERGE) Update package.json to resolve missing types in vite-react app May 18, 2023
@octave08 octave08 added minor Increment the minor version when merged and removed 🐛 Bug Report labels May 18, 2023
@octave08 octave08 changed the title (DO NOT MERGE) Update package.json to resolve missing types in vite-react app Update package.json to resolve missing types in vite-react app May 18, 2023
@octave08 octave08 self-assigned this May 18, 2023
@octave08 octave08 force-pushed the jayhwang-vite-react-types-issue branch from 084f32b to 8b38db5 Compare May 18, 2023 21:00
bengriffin1
bengriffin1 previously approved these changes May 18, 2023
@octave08 octave08 temporarily deployed to production May 18, 2023 21:07 — with GitHub Actions Inactive
@octave08 octave08 added patch Increment the patch version when merged and removed minor Increment the minor version when merged labels Jun 2, 2023
@octave08 octave08 force-pushed the jayhwang-vite-react-types-issue branch from 8b38db5 to 20618d4 Compare June 23, 2023 04:23
@octave08 octave08 changed the title Update package.json to resolve missing types in vite-react app Add typings to package.json export Jun 23, 2023
@octave08 octave08 force-pushed the jayhwang-vite-react-types-issue branch from 20618d4 to 5ec252d Compare June 23, 2023 19:43
@octave08 octave08 temporarily deployed to production June 23, 2023 19:49 — with GitHub Actions Inactive
@sandeepsuresh2020 sandeepsuresh2020 merged commit 42a91e3 into master Jun 23, 2023
@sandeepsuresh2020 sandeepsuresh2020 deleted the jayhwang-vite-react-types-issue branch June 23, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants