Fix TypeScript resolution for @magic-ext/* packages when using modern module resolution (node16 etc) #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipt, for algorand, auth, avalanche, bitcoin, conflux, cosmos, ed25519, flow, gdkms, harmony, hedera, icon, near, oauth, oidc, polkadot, react-native-bare-oauth, react-native-expo-oauth, taquito, terra, tezos, webauthn and zilliqa
|
It looks like I don't have permissions to change the labels on the PR - I assume this is restricted to team members. I would consider this to be a patch PR. |
joshuascan
approved these changes
Nov 21, 2023
|
Thank you so much - this is an amazingly fast response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
This PR updates the
package.jsonfiles for all of the@magic-extpackages (apart from aptos and solana, which already had this change applied).This is essentially the same change that has already been applied in #517 by @octave08 (why wasn't this done for all packages?) and proposed in #626
✅ Fixed Issues
Fixes #669
🚨 Test instructions
Create a new TypeScript web app that uses
node16ornodenextmodule resolution, try to import these packages, TypeScript should be able to perform type checking based on the types of the imported objects.Please only add one label:
patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.