fix: add typings to package.json export #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing the package in a project made with Vite, I get the following error:
This seems to be a known issue when using
moduleResolution: "bundler"
via Vite. You can see the related discussion in microsoft/TypeScript#52363 as well as the same fix applied to other projects [1, 2].This PR adds the missing type specification in
exports
ofpackage.json
.Steps to reproduce
npx vite@latest
.@nostr-dev-kit/ndk-react
package and import it somewhere it in the application.