Skip to content

Workaround PHP7 session_regenerate_id error#2959

Closed
BlackIkeEagle wants to merge 1 commit into
magento:developfrom
BlackIkeEagle:php7-session_regenerate_id-workaround
Closed

Workaround PHP7 session_regenerate_id error#2959
BlackIkeEagle wants to merge 1 commit into
magento:developfrom
BlackIkeEagle:php7-session_regenerate_id-workaround

Conversation

@BlackIkeEagle
Copy link
Copy Markdown
Member

Issue:
When using php7 with memcached all goes well until you goto checkout.
Then the following issue occurs:

Recoverable Error: session_regenerate_id(): Failed to create(read)
session ID: user (path: 127.0.0.1:11211) in
/var/www/website/lib/internal/Magento/Framework/Session/SessionManager.php
on line 473

It is a currently known issue in PHP7:
https://bugs.php.net/bug.php?id=71187

Hereby the workaround to allow people to run magento2 on php7
installations.

Signed-off-by: BlackEagle ike.devolder@gmail.com

@BlackIkeEagle
Copy link
Copy Markdown
Member Author

BAH, its no failure due to the PR

"string with placeholder in escaped double quotes ""%1""","string with placeholder in escaped double quotes ""%1"""
..................................PHP Parse error: syntax error, unexpected 'Gateway' (T_STRING), expecting ';' in /home/travis/build/magento/magento2/setup/src/Magento/Setup/Module/I18n/Dictionary/Phrase.php(274) : eval()'d code on line 1
Parse error: syntax error, unexpected 'Gateway' (T_STRING), expecting ';' in /home/travis/build/magento/magento2/setup/src/Magento/Setup/Module/I18n/Dictionary/Phrase.php(274) : eval()'d code on line 1

@mazhalai
Copy link
Copy Markdown
Contributor

PHP parse error in PHP7 is being fixed in MAGETWO-47301

@cscd98
Copy link
Copy Markdown
Contributor

cscd98 commented Jan 12, 2016

@mazhalai Looking forward to it 👍

@mazhalai
Copy link
Copy Markdown
Contributor

It was merged yesterday, please sync with develop branch again and restart travis builds.

@mazhalai mazhalai added the PS label Jan 12, 2016
@BlackIkeEagle
Copy link
Copy Markdown
Member Author

rebased, so build will run again

@vancoz
Copy link
Copy Markdown

vancoz commented Jan 14, 2016

@BlackIkeEagle can you please add docblock for this method?

Thank you.

@BlackIkeEagle
Copy link
Copy Markdown
Member Author

@vancoz I also made the method looking consistent with the one in DbTable

@vancoz
Copy link
Copy Markdown

vancoz commented Jan 14, 2016

@BlackIkeEagle thank you, internal ticket MAGETWO-47940

@vancoz vancoz added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed Progress: needs update labels Jan 14, 2016
@BlackIkeEagle
Copy link
Copy Markdown
Member Author

@vancoz do you need a new push to fix the test?

The system is going down for power off NOW!
EPHP Warning: PDO::rollBack(): MySQL server has gone away in /home/travis/build/magento/magento2/vendor/magento/zendframework1/library/Zend/Db/Adapter/Pdo/Abstract.php on line 324

something rebooted on the travis side it seems

Issue:
When using php7 with memcached all goes well until you goto checkout.
Then the following issue occurs:

Recoverable Error: session_regenerate_id(): Failed to create(read)
session ID: user (path: 127.0.0.1:11211) in
/var/www/website/lib/internal/Magento/Framework/Session/SessionManager.php
on line 473

It is a currently known issue in PHP7:
https://bugs.php.net/bug.php?id=71187

Hereby the workaround to allow people to run magento2 on php7
installations.

Signed-off-by: BlackEagle <ike.devolder@gmail.com>
magento-team pushed a commit that referenced this pull request Jan 29, 2016
magento-team pushed a commit that referenced this pull request Jan 29, 2016
magento-team pushed a commit that referenced this pull request Jan 29, 2016
@vancoz
Copy link
Copy Markdown

vancoz commented Jan 29, 2016

Pr is merged in scope of MAGETWO-47940

@vancoz vancoz closed this Jan 29, 2016
@mazhalai
Copy link
Copy Markdown
Contributor

This has been merged, so not sure why it is not automatically showing as merged. https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/Session/SaveHandler/Native.php

@BlackIkeEagle
Copy link
Copy Markdown
Member Author

thanks for the feedback

@BlackIkeEagle BlackIkeEagle deleted the php7-session_regenerate_id-workaround branch January 30, 2016 06:16
magento-team pushed a commit that referenced this pull request Sep 18, 2018
Fixed issues:
  - MAGETWO-93981 Create commands to set/show dimension modes for indexers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants