Fix return Type in UrlInterface implementation#2730
Merged
magento-team merged 2 commits intomagento:developfrom Jan 29, 2016
Merged
Fix return Type in UrlInterface implementation#2730magento-team merged 2 commits intomagento:developfrom
magento-team merged 2 commits intomagento:developfrom
Conversation
the function setQueryParam should return \Magento\Framework\UrlInterface but currently returns \Magento\Framework\Url\QueryParamsResolver
Contributor
|
@davidverholen Please merge latest from develop and rerun builds. |
merge upstream develop
Member
Author
|
@mazhalai merged develop from upstream and waiting for the build |
vancoz
added
the
Issue: Ready for Work
|
@davidverholen, thank you for contribution. Internal ticket for this PR is MAGETWO-47940 |
magento-team
pushed a commit
that referenced
this pull request
Jan 29, 2016
magento-team
pushed a commit
that referenced
this pull request
Jan 29, 2016
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 21, 2018
[borg] MAGETWO-91734: Cannot cancel guest order paid with gift card
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the function setQueryParam should return \Magento\Framework\UrlInterface but currently returns \Magento\Framework\Url\QueryParamsResolver