Update AbstractAction#1995
Merged
Merged
Conversation
Updating constructor that Context could have passed as 'Context' rather than fully-qualified name for the future reference. It may cause miss understanding to new comrades in magento 2 who want to dig in magento 2 library. It would be simpler. Issue: Namespace and DI in Magento/Framework/App/Action (lib) discussed. Cheers!
Contributor
|
We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects. |
Contributor
Author
|
https://travis-ci.org/magento/magento2/jobs/83206321 I am seeing these are common failures in all PR. Could you suggest me me to get resolve for above these. Or is it ignorable? |
Contributor
|
@himssri i start a fresh test run, let' wait for the result |
vancoz
added
Issue: Ready for Work
|
@himssri thank you for contribution, internal ticket is MAGETWO-47940 |
magento-team
pushed a commit
that referenced
this pull request
Jan 29, 2016
magento-team
pushed a commit
that referenced
this pull request
Jan 29, 2016
Contributor
Author
|
@vancoz Pleaser! Where can i find my contribution. |
magento-team
pushed a commit
that referenced
this pull request
Jan 26, 2018
[Obsessive Owls] Stabilize Functional Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating constructor that Context could have passed as 'Context' rather than fully-qualified name for the future reference. It may cause miss understanding to new comrades in magento 2 who want to dig in magento 2 library. It would be simpler.
Issue: Namespace and DI in Magento/Framework/App/Action (lib) discussed.
Cheers!