Skip to content

Trim issue on customer confirmation form#16595

Merged
magento-engcom-team merged 4 commits intomagento:2.2-developfrom
gelanivishal:patch-6
Jul 20, 2018
Merged

Trim issue on customer confirmation form#16595
magento-engcom-team merged 4 commits intomagento:2.2-developfrom
gelanivishal:patch-6

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

Related to issue: #6058

Description

Trim email address by remove leading or trailing space in confirmation form

Fixed Issues (if relevant)

  1. IE11 user login email validation fails if field has leading or trailing space #6058: IE11 user login email validation fails if field has leading or trailing space

Manual testing scenarios

  1. Open customer confirmation page in Firefox or IE browser.
  2. Try to add space before entering an email address in the Email field.
  3. Copy " johndoe@domain.com " and paste in the Email field. It will automatically remove leading or trailing space.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Copy Markdown
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ihor-sviziev, here is your new Magento instance.
Admin access: https://pr-16595.engcom.dev.magento.com/admin
Login: admin Password: 123123q

@ihor-sviziev
Copy link
Copy Markdown
Contributor

@magento-engcom-team give me 2.2 instance

@ihor-sviziev
Copy link
Copy Markdown
Contributor

@magento-engcom-team give me 2.2.5 instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.2.5 instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ihor-sviziev, here is your Magento instance.
Admin access: https://i-16595-2-2-5.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ihor-sviziev
Copy link
Copy Markdown
Contributor

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ihor-sviziev, here is your Magento instance.
Admin access: https://i-16595-2-2-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2381 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants