[Forwardport] Trim issue on customer confirmation form#51
Merged
gelanivishal merged 462 commits into2.3-developfrom Jul 20, 2018
Merged
[Forwardport] Trim issue on customer confirmation form#51gelanivishal merged 462 commits into2.3-developfrom
gelanivishal merged 462 commits into2.3-developfrom
Conversation
2.3 develop
…n not be changed to alphanumeric
…popup class to let user click deeper than modals and reach to overlay's div in modal-wrapper div
- Add waitForPageLoad to fix flakiness
…n not be changed to alphanumeric
…n not be changed to alphanumeric
- Replacing waitForElement with waitForPageLoad. - Correcting invalid parameterized selectors. - Adding action group argument type.
- Adding waitForPageLoad to correct a timing issue. - Adding missing website xml.
…nter-events rule to .modal-… magento#16664 - Merge Pull Request magento#16664 from mageprince/magento2:2.3-develop-PR-port-15172 - Merged commits: 1. 76ae28f
…agento#16670 - Merge Pull Request magento#16670 from mageprince/magento2:2.3-develop-PR-port-15791 - Merged commits: 1. a409944
…#16659 - Merge Pull Request magento#16659 from Coderimus/magento2:fix/forward-port-dev-di-info-duplicated-info - Merged commits: 1. 74adebd
…4-file-error-message
…with Export Type UI magento#109
…ect constructor. It caused … magento#16596
# Conflicts: # dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Cms/Section/CmsPagesPageActionsSection.xml # dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Store/Data/StoreData.xml # dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Store/Data/StoreGroupData.xml # dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Store/Section/AdminNewStoreViewActionsSection.xml # dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Store/Section/AdminNewWebsiteActionsSection.xml # dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Store/Section/AdminStoreGroupActionsSection.xml
…y for Multi-store -Updated static noNameSpaceSchema Location respectively to match new location
…error-message [borg] MAGETWO-77744: [Magento Cloud] - Error message when uploading unsupported file format
[earl] MAGETWO-91606: Upgrade to 2.2.2 and above took long time
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#16909: Stabilize Travis CI integration tests suite (by @ishakhsuvarov) - magento#16879: [Port 2.3] Captcha: Added unit test for CheckGuestCheckoutObserver (by @rogyar) - magento#16820: Add missing false-check to the ConfiguredRegularPrice price-model (by @ronak2ram) - magento/graphql-ce#101: Additional checks for fragments added in category tree (by @rogyar) - magento/graphql-ce#102: Fix the category tree depth calculation bug (by @dmytro-ch) - magento/graphql-ce#119: GraphQL-116: Wrong category table name resolving (by @naydav) - magento#16603: [Forwardport] Fix error in payment void method (by @gelanivishal) - magento-engcom/import-export-improvements#109: magento-engcom/import-export-improvements#64: fix issue with Export Type UI (by @dmanners) - magento#16596: [Forwardport] Incorrect value NULL was passed to DataObject constructor. It caused � (by @gelanivishal) - magento#16518: [Forwardport] Use constant time string comparison in FormKey validator (by @gelanivishal) Fixed GitHub Issues: - magento#100: Oracle and Other RDBMS Status? (reported by @dicgf8) has been fixed in magento/graphql-ce#102 by @dmytro-ch in 2.3-develop branch Related commits: 1. 9116d82 - magento#116: EE vs CE (reported by @gondo) has been fixed in magento/graphql-ce#119 by @naydav in 2.3-develop branch Related commits: 1. 4a4bbe2 - magento#16184: Argument 1 passed to Magento\Sales\Model\Order\Payment must be an instance of Magento\Framework\DataObject, none given (reported by @Jakhotiya) has been fixed in magento#16603 by @gelanivishal in 2.3-develop branch Related commits: 1. a1f5fa5
Fixed issues: - MAGETWO-88432: Filesystem Directory Improvement
[borg] MAGETWO-91528: Customizable options truncated when displaying ordered product in admin
[earl] MAGETWO-67627: CMS Page does not save when same url key with hierarchy for Multi-store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#16595
Related to issue: magento#6058
Description
Trim email address by remove leading or trailing space in confirmation form
Fixed Issues (if relevant)
Manual testing scenarios
" johndoe@domain.com "and paste in the Email field. It will automatically remove leading or trailing space.Contribution checklist