You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.
Hi @magento-engcom-team@gelanivishal,
In Magento 2.1 this change causes an error, because it calls the method escapeHtmlAttr on the block, but the method does not exists in Magento\Framework\View\Element\AbstractBlock in Magento 2.1.
The method is added to the class with module version 101.0.0.
As a result you see an empty page if you call /customer/account/confirmation. <?= $block->escapeHtmlAttr($block->getEmail()) ?>
must be changed back to <?php echo $this->helper(\Magento\Framework\EscapeHelper::class)->escapeHtmlAttr($block->getEmail()) ?> to fix this problem.
Hi @matthiashamacher,
Could you create separate issue for this or even better PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16595
Related to issue: #6058
Description
Trim email address by remove leading or trailing space in confirmation form
Fixed Issues (if relevant)
Manual testing scenarios
" johndoe@domain.com "and paste in the Email field. It will automatically remove leading or trailing space.Contribution checklist