Skip to content

[Forwardport] Correct typo correction js files#16113

Closed
hitesh-wagento wants to merge 25 commits intomagento:2.3-developfrom
hitesh-wagento:2.3-develop-PR-port-correct-typo-correction
Closed

[Forwardport] Correct typo correction js files#16113
hitesh-wagento wants to merge 25 commits intomagento:2.3-developfrom
hitesh-wagento:2.3-develop-PR-port-correct-typo-correction

Conversation

@hitesh-wagento
Copy link
Copy Markdown
Contributor

Correct typo correction js files

Fixed Issues (if relevant)

#15888

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

hitesh-wagento and others added 25 commits June 5, 2018 09:54
[Forwardport] [Resolved : Styling <select> by changing less variables in Luma theme…
[Forwardport] [Changed indentation 2 to 4]
[Forwardport] Add missing table aliases to fields mapping for Customer Group filter…
[Forwardport] [Resolved : limiter float too generic]
[Forwardport] [Resolved : Changing @tab-content__border variable has no effect in B…
[Forwardport] Attribute set save admin controller refactor
[Forwardport] Postpone instantiation of session config by using a proxy
@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 14, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@hitesh-wagento
Copy link
Copy Markdown
Contributor Author

@saurabh-aureate why are you close my PR?

@VladimirZaets
Copy link
Copy Markdown
Contributor

Hi @hitesh-wagento, thank you for collaboration, this PR contains more than typo correction js files, also, origin PR contains only two files with changes instead of nine in your PR. Can you explain the reason?

@hitesh-wagento
Copy link
Copy Markdown
Contributor Author

Hi @VladimirZaets

I have done only below changes in two files
f2976b2

@VladimirZaets
Copy link
Copy Markdown
Contributor

@hitesh-wagento Please, have a look to the header of your PR. Currently, your branch contains 9 changed files. Please, actualizing changes in your branch.
screen shot 2018-06-15 at 11 34 28

@hitesh-wagento
Copy link
Copy Markdown
Contributor Author

Hi @VladimirZaets

I don't know why it's showing 9 files changed.

@VladimirZaets
Copy link
Copy Markdown
Contributor

@hitesh-wagento because your branch contains 25 commits. Please, create the new branch that will based on current Magento 2.3-develop branch and push your changes to it.

@hitesh-wagento hitesh-wagento deleted the 2.3-develop-PR-port-correct-typo-correction branch September 6, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants