[Forwardport] Attribute set save admin controller refactor#13
Merged
hitesh-wagento merged 113 commits into2.3-developfrom Jun 12, 2018
Merged
[Forwardport] Attribute set save admin controller refactor#13hitesh-wagento merged 113 commits into2.3-developfrom
hitesh-wagento merged 113 commits into2.3-developfrom
Conversation
…count down as more characters are entered
…count down as more characters are entered
…count down as more characters are entered - Refactor based on review comments
…count down as more characters are entered - Add unit test
…count down as more characters are entered
…to MAGETWO-91848-max-characters
…ter view edit mini cart returns empty shopping cart
…elds list magento#83 - Merge Pull Request magento/graphql-ce#83 from sergy-gzh/graphql-ce:bugfix/26-imit-list-of-filterable-fields - Merged commits: 1. 38180f2
…tion for Braintree
…437-Category-Product-Indexer [honey] MAGETWO-91437: Catalog_category_product_index table doesn't update after deleting category
…haracters [borg] MAGETWO-91848: Hint on product option with Maximum Characters should count down as more characters are entered
…ternal extensions
…OM-1833-magento-graphql-ce-83
…to-graphql-ce-83 Engcom 1833 magento graphql ce 83
…namespace-agnostic-2.3-develop
…tests-namespace-agnostic-2.3-develop [borg] MAGETWO-92468: Make PR testsuite namespace-agnostic
…definition does not requir… magento#15948 - Merge Pull Request magento#15948 from saurabh-aureate/magento2:2.3-develop-PR-port-15891 - Merged commits: 1. f752b9e
…earchCriteria - added zero … magento#15946 - Merge Pull Request magento#15946 from vgelani/magento2:2.3-develop-PR-port-15322 - Merged commits: 1. d76fe20
…nternal\Magento\Framework\D… magento#15944 - Merge Pull Request magento#15944 from vgelani/magento2:2.3-develop-PR-port-15892 - Merged commits: 1. 681e65f 2. cb0108f
…nternal\Magento\Framework\D… magento#15944
…earchCriteria - added zero … magento#15946
…definition does not requir… magento#15948
Accepted Public Pull Requests: - magento#15944: [Forwardport] Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D� (by @vgelani) - magento#15946: [Forwardport] ISSUE-11477 - fixed Swagger response for searchCriteria - added zero � (by @vgelani) - magento#15948: [Forwardport]No need to pass method parameter as method definition does not requir� (by @saurabh-aureate) Fixed GitHub Issues: - magento#11477: Magento REST API Schema (Swagger) is not compatible with Search Criteria (reported by @careys7) has been fixed in magento#15946 by @vgelani in 2.3-develop branch Related commits: 1. d76fe20
[TSG] Upporting for 2.3 (pr22) (2.3.0)
Fix static test failures
Fix static test failures
hitesh-wagento
pushed a commit
that referenced
this pull request
Jul 14, 2018
[Forwardport] Corrected Magento_Framework's test xml file.
hitesh-wagento
pushed a commit
that referenced
this pull request
Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15990
Description
Remove direct use of object manager for admin attribute set save controller using constructor based dependency injection.
Manual testing scenarios
Created a new attribute set in admin under Stores -> Attribute Set -> Add Attribute Set.
Edit an existing attribute set under Stores -> Attribute Set