[Forwardport] [Resolved : limiter float too generic]#8
Merged
hitesh-wagento merged 6 commits into2.3-developfrom Jun 6, 2018
Merged
[Forwardport] [Resolved : limiter float too generic]#8hitesh-wagento merged 6 commits into2.3-developfrom
hitesh-wagento merged 6 commits into2.3-developfrom
Conversation
- added functional test to cover bug fix
- addressed CR comments
[arcticfoxes] MAGETWO-91434: Default option for 'Status' attribute not being set
hitesh-wagento
pushed a commit
that referenced
this pull request
Jul 14, 2018
[Forwardport] Fixed type hints and docs for Downloadable Samples block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15878
.limiter should have the same parent selectors like .pages to prevent clashes between styles and layouts
Description
Added selector for floating the element
.limiterFixed Issues (if relevant)
Manual testing scenarios
.limiterand.pagesActual Result
.limiteris too generic and is used as single selector for floating the elementExpected Result
.limitershould have the same parent selectors like .pages to prevent clashes between styles and layoutsContribution checklist