Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Fix overriding of payment methods in getPaymentMethodList #15032

Merged
merged 1 commit into from
May 9, 2018

Conversation

mashb1t
Copy link
Member

@mashb1t mashb1t commented May 7, 2018

Fixes Issue #13460, keeps changes from pull request #12284

Description

This fix only sets the value of a group if it doesn't already exist when calling \Magento\Payment\Helper\Data::getPaymentMethodList with parameter $withGroups = true.

Fixed Issues

#13460
#12284

Manual testing scenarios

  1. Call method \Magento\Payment\Helper\Data::getPaymentMethodList
  2. Value of group e.g. "offline" in $labelValues doesn't get set to null because there are already group-related values such as "checkmo".

@VladimirZaets
Copy link
Contributor

Hi, @mash1t, I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Contributor

@mash1t thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@mashb1t
Copy link
Member Author

mashb1t commented May 7, 2018

@magento-engcom-team i am already a member of the magento team. What exactly did you mean by "extended permissions"?

@VladimirZaets
Copy link
Contributor

@mash1t It's automated comment. extended permissions it's permissions that give the ability to Magento team for push to your branch.

@magento-engcom-team
Copy link
Contributor

Hi @mash1t. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@pascalhansjosten
Copy link

Hey @magento-engcom-team ,

i would like to ask if this fix is available on release 2.2.5?

Best regards,
Pascal Hansjosten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants