Issue: 3596. Resolve Notice with undefined index 'value'

[madonzy]

Fix for issue: #3596

Description

If you have a custom offline payment method it automatically falls in exception group used while fetching all payment methods this cause that payment method don't have value key in the definition and as the result - undefined index on order view page in admin panel. My fix adds key value as null and it fixes the notice.

Fixed Issues

1. Notice: Undefined index: value in /app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Select.php on line 72 #3596: Notice: Undefined index: value in /app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Select.php on line 72

Manual testing scenarios

1. Add custom offline payment method
2. Create an order with instantly payable payment method (like PayPal, PayPal, ... not the bank transfer)
3. Got to order view in admin panel and you should PHP notice.

Contribution checklist

• [ + ] Pull request has a meaningful description of its purpose
• [ + ] All commits are accompanied by meaningful commit messages
• [ + ] All new or changed code is covered with unit/integration tests (if applicable)
• [ + ] All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[okorshenko]

Hi @madonzy
Thank you for your contribution. We can not accept this PR to 2.1 until it is fixed in 2.2
Could you please create PR to 2.2 so that we can accept PR to 2.1
Thank you

[madonzy]

@okorshenko yes, sure here it is: #12296

[madonzy]

@okorshenko, how can I become visible in contributors list? Maybe you can add me to magento2 group?