Renamed "Add Block Names to Hints" config setting to represent what it actually does#14939
Merged
magento-engcom-team merged 4 commits intomagento:2.2-developfrom May 3, 2018
AbsoluteCommerce:absolute/block-class-type-config-label
Merged
Renamed "Add Block Names to Hints" config setting to represent what it actually does#14939magento-engcom-team merged 4 commits intomagento:2.2-developfrom AbsoluteCommerce:absolute/block-class-type-config-label
magento-engcom-team merged 4 commits intomagento:2.2-developfrom
AbsoluteCommerce:absolute/block-class-type-config-label
Conversation
Merging upstream
Merge upstream
This config name is notoriously misleading as it does not show the block name at all, instead it shows the block class type. Worse still there is a question about this in the Magento2 certification exam which is utterly confusing due to the poor naming of the config setting.
Contributor
|
@chris-pook thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Contributor
|
Hi, @chris-pook , I took your PR into processing, thank you for collaboration. |
magento-engcom-team
pushed a commit
that referenced
this pull request
May 3, 2018
…resent what it actually does #14939
Contributor
|
Hi @chris-pook. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This config name is notoriously misleading as it does not show the block name at all, instead it shows the block class type. Worse still there is a question about this in the Magento2 certification exam which is utterly confusing due to the poor naming of the config setting.
Description
I have updated the label of this config setting to state what it actually does when enabled, displaying the block class type on the hints.
Fixed Issues (if relevant)
n/a
Manual testing scenarios
Contribution checklist