Skip to content

[Forwardport] Renamed "Add Block Names to Hints" config setting to represent what it actually does#12

Merged
adrian-martinez-interactiv4 merged 1 commit into2.3-developfrom
2.3-develop-PR-port-14939
Oct 8, 2018
Merged

[Forwardport] Renamed "Add Block Names to Hints" config setting to represent what it actually does#12
adrian-martinez-interactiv4 merged 1 commit into2.3-developfrom
2.3-develop-PR-port-14939

Conversation

@adrian-martinez-interactiv4
Copy link
Copy Markdown
Owner

Original Pull Request

magento#14939
This config name is notoriously misleading as it does not show the block name at all, instead it shows the block class type. Worse still there is a question about this in the Magento2 certification exam which is utterly confusing due to the poor naming of the config setting.

Description

I have updated the label of this config setting to state what it actually does when enabled, displaying the block class type on the hints.

Fixed Issues (if relevant)

n/a

Manual testing scenarios

  • Login to admin, view updated configuration label.
  • Set config to "Yes", confirm block class types are still being shown on template hints.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

This config name is notoriously misleading as it does not show the block name at all, instead it shows the block class type. Worse still there is a question about this in the Magento2 certification exam which is utterly confusing due to the poor naming of the config setting.
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 merged commit 7238228 into 2.3-develop Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants