[Backport] "Add Block Names to Hints" config setting to represent what it actually does#15105
Merged
magento-engcom-team merged 1 commit intomagento:2.1-developfrom May 9, 2018
Conversation
magento-engcom-team
added
Release Line: 2.1
Partner: Atwix
magento-engcom-team
pushed a commit
that referenced
this pull request
May 9, 2018
…represent what it actually does #15105
Contributor
|
Hi @sergiy-v. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #14939.
This config name is notoriously misleading as it does not show the block name at all, instead it shows the block class type. Worse still there is a question about this in the Magento2 certification exam which is utterly confusing due to the poor naming of the config setting.
Description
I have updated the label of this config setting to state what it actually does when enabled, displaying the block class type on the hints.
Fixed Issues (if relevant)
n/a
Manual testing scenarios
Login to admin, view updated configuration label.
Set config to "Yes", confirm block class types are still being shown on template hints.